Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for hostAliases #207

Closed
wants to merge 2 commits into from
Closed

Conversation

pcc-damatj
Copy link

Description of the change

Adds support for hostAliases

Existing or Associated Issue(s)

Closes #204

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@pcc-damatj pcc-damatj requested a review from a team as a code owner July 15, 2024 16:17
Signed-off-by: Joel Damata <[email protected]>
Signed-off-by: Joel Damata <[email protected]>
Copy link

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Jul 23, 2024
@ChrisJBurns
Copy link
Contributor

Hey @pcc-damatj , would you be able to add some ci tests maybe for this?

@github-actions github-actions bot removed the stale label Jul 28, 2024
Copy link

github-actions bot commented Aug 4, 2024

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Aug 4, 2024
@github-actions github-actions bot closed this Aug 9, 2024
@ChrisJBurns ChrisJBurns reopened this Aug 12, 2024
@github-actions github-actions bot removed the stale label Aug 13, 2024
Copy link

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Aug 21, 2024
@ChrisJBurns
Copy link
Contributor

@pcc-damatj DId you manage to run the pre-commit hook? As the CI actions seems to be failing on that step

@github-actions github-actions bot removed the stale label Aug 22, 2024
Copy link

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Aug 30, 2024
@github-actions github-actions bot closed this Sep 5, 2024
@ChrisJBurns ChrisJBurns reopened this Sep 5, 2024
@ChrisJBurns
Copy link
Contributor

I still think the PR is valid, it just needs rebasing and running of the pre-commit steps

@github-actions github-actions bot removed the stale label Sep 6, 2024
Copy link

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

Copy link

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Sep 26, 2024
@vinzscam vinzscam removed the stale label Sep 26, 2024
Copy link

github-actions bot commented Oct 4, 2024

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Oct 4, 2024
@github-actions github-actions bot closed this Oct 9, 2024
@ChrisJBurns ChrisJBurns reopened this Nov 4, 2024
@ChrisJBurns
Copy link
Contributor

@pcc-damatj Did you wan this change to be added? If you haven't got the time I could put a quick PR up and get it in

@github-actions github-actions bot removed the stale label Nov 5, 2024
@coreydaley coreydaley mentioned this pull request Nov 11, 2024
4 tasks
@coreydaley
Copy link
Contributor

Superseded by #234

@ChrisJBurns
Copy link
Contributor

Closing because functionality was added in #234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support hostAliases
5 participants