Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for hostAliases #234

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

coreydaley
Copy link
Contributor

@coreydaley coreydaley commented Nov 11, 2024

Adds support for hostAliases
Builds upon and supersedes #207

Description of the change

Existing or Associated Issue(s)

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@coreydaley coreydaley requested a review from a team as a code owner November 11, 2024 15:13
@coreydaley
Copy link
Contributor Author

@ChrisJBurns I pulled in #207 and bumped the chart version and ran the pre-commit. Let me know if anything else needs to be done for this one. Thanks!

@coreydaley coreydaley mentioned this pull request Nov 11, 2024
4 tasks
Copy link
Member

@vinzscam vinzscam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ChrisJBurns
Copy link
Contributor

Good stuff, cheers bud @coreydaley . Allows us to close #207 as well

@ChrisJBurns ChrisJBurns merged commit b0e982d into backstage:main Nov 13, 2024
3 checks passed
@coreydaley
Copy link
Contributor Author

Thanks @ChrisJBurns !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants