fix test bug #121
fix test bug #121
Conversation
tech-andgar
commented
Feb 22, 2024
tech-andgar
commented
- feat: add job test on CI/CD pipeline
- test: fixed bug tests
- chore: downgraded the analyzer dependency from version 6.0.0 to 5.13.0 for compatibility reason is test pass.
- style: smell code
Enhanced the formatting of CHANGELOG.md, GOVERNANCE.md, and README.md for better readability. Updated workflow files and fixed minor issues in the documentation.
Updated the URLs used in test assertions to point to the new documentation location. This change affects multiple tests across different files, ensuring they align with recent changes in our documentation structure.
Adjusted the expected values in the cyclomatic complexity and source lines of code metric tests. This includes reducing the expected length of complexity entities and updating offset values. Also, improved test grouping naming in analysis_options_utils_test.
Downgraded the analyzer dependency from version 6.0.0 to 5.13.0 for compatibility reasons.
Added a new step in the GitHub Actions build workflow to run Dart tests after installing dependencies.
| @@ -12,7 +12,7 @@ platforms: | |||
| macos: | |||
|
|
|||
| dependencies: | |||
| analyzer: ^6.0.0 | |||
| analyzer: ^5.13.0 | |||
There was a problem hiding this comment.
this PR #110 fixed that, please continue using analyzer: ^6.0.0
thanks for your help
There was a problem hiding this comment.
Thank you for your response. I attempted to upgrade to the latest version 6.0.0, but it doesn't work with this PR because of the incompatibility introduced by analyzer 6.0.0, which implemented 'final' and this affects the functionality. I tried to clone the analyzer project, but it's out of my reach. I hope you consider this regarding the PR. In my opinion, this PR will be closed due to being out of scope.
There was a problem hiding this comment.
maybe you can complete issues in separated PR: feat: add job test on CI/CD pipeline maybe in one PR,
finally in other PR you can complete style: smell code.
Regards
