fix test bug

.github/workflows/Handler-Comment-Issues.yml

@@ -1,5 +1,5 @@
-name: workflow of automations dispatch to commands in comments 
-on: 
+name: workflow of automations dispatch to commands in comments
+on:
   issue_comment:
     types: [created]
 env:
@@ -31,7 +31,7 @@ jobs:
         run: |
           if [[ ${COMMENT,,} == *"$CMD_ACCEPT_REVIEW"* ]];
           then
-            if [[ ${VAR_USERS_REVIEWERS,,} =~ ${USER_COMMENT,,} ]];    
+            if [[ ${VAR_USERS_REVIEWERS,,} =~ ${USER_COMMENT,,} ]];
             then
               gh issue edit $ISSUE_URL --remove-label "Review/Pending"
               gh issue edit $ISSUE_URL --add-label "Review/Approved"

.github/workflows/build.yaml

@@ -17,4 +17,6 @@ jobs:
           channel: stable
           version: 3.13.8
       - name: Install dependencies
-        run: dart pub get
+        run: dart pub get
+      - name: Run Tests
+        run: dart test

.github/workflows/release.yaml

@@ -4,7 +4,7 @@ name: Publish to pub.dev
 on:
   push:
     tags:
-    - 'v[0-9]+.[0-9]+.[0-9]+*' 
+    - 'v[0-9]+.[0-9]+.[0-9]+*'
 jobs:
   publish:
     name: 'Publish to pub.dev'
@@ -23,4 +23,4 @@ jobs:
       - name: Install dependencies
         run: dart pub get
       - name: Publish to pub.dev
-        run: dart pub publish -f
+        run: dart pub publish -f

CHANGELOG.md

@@ -1,19 +1,31 @@
 # Changelog
+
+## 1.1.3
+
+- Fix: bug tests
+
 ## 1.1.2
+
 - append new presset `analysis_options.1.0.0.yaml`
+
 ## 1.1.1
+
 - Rename common rules to dart rules
+
 ## 1.1.0
+
 - Added new presets
 - Removed Angular framework rules
 - Added example
 
 ## 1.0.2
+
 - Fix: report in IDE'S is adjusted
+
 ## 1.0.1
+
 - Automated publishing of packages to pub.dev
 
 ## 1.0.0
-- Fork: [Dart code metrics 5.7.3](https://github.com/dart-code-checker/dart-code-metrics)
-
 
+- Fork: [Dart code metrics 5.7.3](https://github.com/dart-code-checker/dart-code-metrics)

GOVERNANCE.md

@@ -4,10 +4,10 @@
 
 ![Modelo de Gobierno](Roles-EN.png)
 
-| Roles | Responsibilities |
-| ---------------- | ------------------------------------------------------------ |
-| Product Owners | lead the open initiative and its projects, have a short, medium and long-term vision of the initiative and projects. Have criteria when making decisions. abdicate when it is for the good of the community and the project.
-| Maintainers | Maintainers have greater authority and responsibility in overall project management and coordination.
-| Trusted Committer | "Trusted committers" are contributors who have the ability to commit changes directly to the project repository and review others' contributions, but their authority is limited compared to maintainers |
-Contributors | Actively contribute with *commits*, *reviews* |
-Community Leader | Promotes *participation*, *collaboration*, provides necessary tools that facilitate communication with the community |
+| Roles             | Responsibilities                                                                                                                                                                                                             |
+| ----------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
+| Product Owners    | lead the open initiative and its projects, have a short, medium and long-term vision of the initiative and projects. Have criteria when making decisions. abdicate when it is for the good of the community and the project. |
+| Maintainers       | Maintainers have greater authority and responsibility in overall project management and coordination.                                                                                                                        |
+| Trusted Committer | "Trusted committers" are contributors who have the ability to commit changes directly to the project repository and review others' contributions, but their authority is limited compared to maintainers                     |
+| Contributors      | Actively contribute with *commits*, *reviews*                                                                                                                                                                                |
+| Community Leader  | Promotes *participation*, *collaboration*, provides necessary tools that facilitate communication with the community                                                                                                         |

README.md

@@ -1,9 +1,9 @@
-## Dart Code Linter
+# Dart Code Linter
+
 [![Pub](https://img.shields.io/pub/v/dart_code_linter.svg)](https://pub.dev/packages/dart_code_linter)
 
 Dart Code Linter (DCL) is a powerful toolkit designed to enhance your development process by identifying and resolving issues within your Dart and Flutter code. Whether you're dealing with potential runtime bugs, violations of best practices, or styling concerns, DCL has got you covered. With a comprehensive collection of over 70 pre-built rules, you can effortlessly validate your code against a variety of expectations. Furthermore, DCL offers the flexibility to customize these rules to cater to your specific requirements, ensuring an optimized coding experience.
 
-
 ## Links
 
 - See [CHANGELOG.md](./CHANGELOG.md) for major/breaking updates, and [releases](https://github.com/bancolombia/dart-code-linter/releases) for a detailed version history.
@@ -23,7 +23,6 @@ $ flutter pub add --dev dart_code_linter
 
 Add configuration to `analysis_options.yaml` and reload IDE to allow the analyzer to discover the plugin config.
 
-
 ### Basic config example
 
 ```yaml title="analysis_options.yaml"
@@ -94,7 +93,6 @@ Rules that marked with 🛠 have auto-fixes available through the IDE context me
 
 ![VS Code example](https://github.com/bancolombia/dart-code-linter/blob/trunk/assets/quick-fixes.png)
 
-
 ### CLI
 
 The package can be used as CLI and supports multiple commands:
@@ -132,8 +130,6 @@ It will produce a result in one of the format:
 - HTML
 - JSON
 
-
-
 #### Check unnecessary nullable parameters
 
 Checks unnecessary nullable parameters in functions, methods, constructors. To execute the command, run
@@ -150,8 +146,6 @@ It will produce a result in one of the format:
 - Console
 - JSON
 
-
-
 #### Check unused files
 
 Checks unused `*.dart` files. To execute the command, run
@@ -202,7 +196,6 @@ It will produce a result in one of the format:
 - Console
 - JSON
 
-
 #### Check unused code
 
 Checks unused code in `*.dart` files. To execute the command, run
@@ -219,8 +212,6 @@ It will produce a result in one of the format:
 - Console
 - JSON
 
-
-
 ## Troubleshooting
 
 Please read [the following guide](./TROUBLESHOOTING.md) if the plugin is not working as you'd expect it to work.
@@ -230,4 +221,5 @@ Please read [the following guide](./TROUBLESHOOTING.md) if the plugin is not wor
 If you are interested in contributing, please check out the [contribution guidelines](./CONTRIBUTING.md). Feedback and contributions are welcome!
 
 ## License
+
 Dart Code Linter is licensed under the [MIT](./LICENSE)

TROUBLESHOOTING.md

@@ -20,4 +20,3 @@ If the plugin is not working as you'd expect it to work, please consider going t
     then a `Analyzer Server Diagnostics` webpage will be opened.
 
     To check that the plugin is active, open the `Plugins` tab and ensure that there is no errors.
-

lib/src/version.dart

@@ -1 +1 @@
-const packageVersion = '1.1.2';
+const packageVersion = '1.1.3';

pubspec.yaml

@@ -1,5 +1,5 @@
 name: dart_code_linter
-version: 1.1.2
+version: 1.1.3
 description: Dart Code Linter is a software analytics tool that helps developers analyse and improve software quality. Dart Code Linter is based on a fork of Dart Code Metrics.
 repository: https://github.com/bancolombia/dart-code-linter
 
@@ -12,7 +12,7 @@ platforms:
   macos:
 
 dependencies:
-  analyzer: ^6.0.0
+  analyzer: ^5.13.0
   analyzer_plugin: ^0.11.0
   ansicolor: ^2.0.1
   args: ^2.0.0

test/src/analyzers/lint_analyzer/metrics/metrics_list/cyclomatic_complexity/cyclomatic_complexity_flow_visitor_test.dart

@@ -22,7 +22,7 @@ Future<void> main() async {
         final visitor = CyclomaticComplexityFlowVisitor();
         declaration.visitChildren(visitor);
 
-        expect(visitor.complexityEntities, hasLength(14));
+        expect(visitor.complexityEntities, hasLength(13));
       });
 
       test('common function', () {

test/src/analyzers/lint_analyzer/metrics/metrics_list/cyclomatic_complexity/cyclomatic_complexity_metric_test.dart

@@ -29,12 +29,12 @@ Future<void> main() async {
       );
 
       expect(metricValue.metricsId, equals(metric.id));
-      expect(metricValue.value, equals(15));
+      expect(metricValue.value, equals(14));
       expect(metricValue.level, equals(MetricValueLevel.warning));
       expect(
         metricValue.comment,
         equals(
-          'This function has a cyclomatic complexity of 15, which exceeds the maximum of 10 allowed.',
+          'This function has a cyclomatic complexity of 14, which exceeds the maximum of 10 allowed.',
         ),
       );
       expect(metricValue.recommendation, isNull);
@@ -46,7 +46,6 @@ Future<void> main() async {
           'Conditional expression increases complexity',
           'For statement increases complexity',
           'If statement increases complexity',
-          'Switch case increases complexity',
           'Switch default increases complexity',
           'While statement increases complexity',
           'Yield statement increases complexity',

test/src/analyzers/lint_analyzer/metrics/metrics_list/source_lines_of_code/source_lines_of_code_metric_test.dart

@@ -41,8 +41,8 @@ Future<void> main() async {
         metricValue.context.single.message,
         equals('line contains source code'),
       );
-      expect(metricValue.context.single.location.start.offset, equals(450));
-      expect(metricValue.context.single.location.end.offset, equals(450));
+      expect(metricValue.context.single.location.start.offset, equals(446));
+      expect(metricValue.context.single.location.end.offset, equals(446));
     });
 
     test('class method', () {

test/src/analyzers/lint_analyzer/reporters/reporters_list/html/components/report_details_tooltip_test.dart

@@ -28,7 +28,7 @@ void main() {
             'Entity',
           ).outerHtml,
           equals(
-            '<div class="metrics-source-code__tooltip"><div class="metrics-source-code__tooltip-title">Entity&amp;nbsp;stats:</div><p class="metrics-source-code__tooltip-text"><div class="metrics-source-code__tooltip-section"><p class="metrics-source-code__tooltip-text"><a class="metrics-source-code__tooltip-link" href="https://dcl.apps.bancolombia.com/metrics/metric" target="_blank" rel="noopener noreferrer" title="metric">metric:&amp;nbsp;</a><span>10</span></p><p class="metrics-source-code__tooltip-text"><span class="metrics-source-code__tooltip-label">metric violation level:&amp;nbsp;</span><span class="metrics-source-code__tooltip-level metrics-source-code__tooltip-level--warning">warning</span></p></div></p><p class="metrics-source-code__tooltip-text"><div class="metrics-source-code__tooltip-section"><p class="metrics-source-code__tooltip-text"><a class="metrics-source-code__tooltip-link" href="https://dcl.apps.bancolombia.com/metrics/metric%202" target="_blank" rel="noopener noreferrer" title="metric 2">metric 2:&amp;nbsp;</a><span>2</span></p><p class="metrics-source-code__tooltip-text"><span class="metrics-source-code__tooltip-label">metric 2 violation level:&amp;nbsp;</span><span class="metrics-source-code__tooltip-level metrics-source-code__tooltip-level--noted">noted</span></p></div></p><p class="metrics-source-code__tooltip-text"><div class="metrics-source-code__tooltip-section"><p class="metrics-source-code__tooltip-text"><a class="metrics-source-code__tooltip-link" href="https://dcl.apps.bancolombia.com/metrics/number-of-methods" target="_blank" rel="noopener noreferrer" title="metric1">metric1:&amp;nbsp;</a><span>0</span></p><p class="metrics-source-code__tooltip-text"><span class="metrics-source-code__tooltip-label">metric1 violation level:&amp;nbsp;</span><span class="metrics-source-code__tooltip-level metrics-source-code__tooltip-level--none">none</span></p></div></p><p class="metrics-source-code__tooltip-text"><div class="metrics-source-code__tooltip-section"><p class="metrics-source-code__tooltip-text"><a class="metrics-source-code__tooltip-link" href="https://dcl.apps.bancolombia.com/metrics/weight-of-class" target="_blank" rel="noopener noreferrer" title="metric2">metric2:&amp;nbsp;</a><span>1</span></p><p class="metrics-source-code__tooltip-text"><span class="metrics-source-code__tooltip-label">metric2 violation level:&amp;nbsp;</span><span class="metrics-source-code__tooltip-level metrics-source-code__tooltip-level--none">none</span></p></div></p></div>',
+            '<div class="metrics-source-code__tooltip"><div class="metrics-source-code__tooltip-title">Entity&amp;nbsp;stats:</div><p class="metrics-source-code__tooltip-text"><div class="metrics-source-code__tooltip-section"><p class="metrics-source-code__tooltip-text"><a class="metrics-source-code__tooltip-link" href="https://dcl.apps.bancolombia.com/docs/metrics/metric" target="_blank" rel="noopener noreferrer" title="metric">metric:&amp;nbsp;</a><span>10</span></p><p class="metrics-source-code__tooltip-text"><span class="metrics-source-code__tooltip-label">metric violation level:&amp;nbsp;</span><span class="metrics-source-code__tooltip-level metrics-source-code__tooltip-level--warning">warning</span></p></div></p><p class="metrics-source-code__tooltip-text"><div class="metrics-source-code__tooltip-section"><p class="metrics-source-code__tooltip-text"><a class="metrics-source-code__tooltip-link" href="https://dcl.apps.bancolombia.com/docs/metrics/metric%202" target="_blank" rel="noopener noreferrer" title="metric 2">metric 2:&amp;nbsp;</a><span>2</span></p><p class="metrics-source-code__tooltip-text"><span class="metrics-source-code__tooltip-label">metric 2 violation level:&amp;nbsp;</span><span class="metrics-source-code__tooltip-level metrics-source-code__tooltip-level--noted">noted</span></p></div></p><p class="metrics-source-code__tooltip-text"><div class="metrics-source-code__tooltip-section"><p class="metrics-source-code__tooltip-text"><a class="metrics-source-code__tooltip-link" href="https://dcl.apps.bancolombia.com/docs/metrics/number-of-methods" target="_blank" rel="noopener noreferrer" title="metric1">metric1:&amp;nbsp;</a><span>0</span></p><p class="metrics-source-code__tooltip-text"><span class="metrics-source-code__tooltip-label">metric1 violation level:&amp;nbsp;</span><span class="metrics-source-code__tooltip-level metrics-source-code__tooltip-level--none">none</span></p></div></p><p class="metrics-source-code__tooltip-text"><div class="metrics-source-code__tooltip-section"><p class="metrics-source-code__tooltip-text"><a class="metrics-source-code__tooltip-link" href="https://dcl.apps.bancolombia.com/docs/metrics/weight-of-class" target="_blank" rel="noopener noreferrer" title="metric2">metric2:&amp;nbsp;</a><span>1</span></p><p class="metrics-source-code__tooltip-text"><span class="metrics-source-code__tooltip-label">metric2 violation level:&amp;nbsp;</span><span class="metrics-source-code__tooltip-level metrics-source-code__tooltip-level--none">none</span></p></div></p></div>',
           ),
         );
       },
@@ -46,7 +46,7 @@ void main() {
             ),
           ).outerHtml,
           equals(
-            '<div class="metrics-source-code__tooltip-section"><p class="metrics-source-code__tooltip-text"><a class="metrics-source-code__tooltip-link" href="https://dcl.apps.bancolombia.com/metrics/metric" target="_blank" rel="noopener noreferrer" title="metric">metric:&amp;nbsp;</a><span>10</span></p><p class="metrics-source-code__tooltip-text"><span class="metrics-source-code__tooltip-label">metric violation level:&amp;nbsp;</span><span class="metrics-source-code__tooltip-level metrics-source-code__tooltip-level--warning">warning</span></p></div>',
+            '<div class="metrics-source-code__tooltip-section"><p class="metrics-source-code__tooltip-text"><a class="metrics-source-code__tooltip-link" href="https://dcl.apps.bancolombia.com/docs/metrics/metric" target="_blank" rel="noopener noreferrer" title="metric">metric:&amp;nbsp;</a><span>10</span></p><p class="metrics-source-code__tooltip-text"><span class="metrics-source-code__tooltip-label">metric violation level:&amp;nbsp;</span><span class="metrics-source-code__tooltip-level metrics-source-code__tooltip-level--warning">warning</span></p></div>',
           ),
         );
 
@@ -60,7 +60,7 @@ void main() {
             ),
           ).outerHtml,
           equals(
-            '<div class="metrics-source-code__tooltip-section"><p class="metrics-source-code__tooltip-text"><a class="metrics-source-code__tooltip-link" href="https://dcl.apps.bancolombia.com/metrics/metric" target="_blank" rel="noopener noreferrer" title="metric">metric:&amp;nbsp;</a><span>10 units</span></p><p class="metrics-source-code__tooltip-text"><span class="metrics-source-code__tooltip-label">metric violation level:&amp;nbsp;</span><span class="metrics-source-code__tooltip-level metrics-source-code__tooltip-level--warning">warning</span></p></div>',
+            '<div class="metrics-source-code__tooltip-section"><p class="metrics-source-code__tooltip-text"><a class="metrics-source-code__tooltip-link" href="https://dcl.apps.bancolombia.com/docs/metrics/metric" target="_blank" rel="noopener noreferrer" title="metric">metric:&amp;nbsp;</a><span>10 units</span></p><p class="metrics-source-code__tooltip-text"><span class="metrics-source-code__tooltip-label">metric violation level:&amp;nbsp;</span><span class="metrics-source-code__tooltip-level metrics-source-code__tooltip-level--warning">warning</span></p></div>',
           ),
         );
       },

test/src/analyzers/lint_analyzer/rules/rule_utils_test.dart

@@ -16,7 +16,7 @@ void main() {
       () {
         const id = 'rule-id';
         final documentationUrl = Uri.parse(
-          'https://dcl.apps.bancolombia.com/rules/flutter/rule-id',
+          'https://dcl.apps.bancolombia.com/docs/rules/flutter/rule-id',
         );
         const severity = Severity.none;
 
@@ -72,7 +72,7 @@ void main() {
       expect(
         documentation(rule1).toString(),
         equals(
-          'https://dcl.apps.bancolombia.com/rules/flutter/$ruleId1',
+          'https://dcl.apps.bancolombia.com/docs/rules/flutter/$ruleId1',
         ),
       );
 

test/src/analyzers/lint_analyzer/rules/rules_list/list_all_equatable_fields/list_all_equatable_fields_rule_test.dart

@@ -22,7 +22,7 @@ void main() {
 
       expect(
         documentationUri.path,
-        equals('/docs/individuals/rules/common/list-all-equatable-fields'),
+        equals('/docs/rules/dart/list-all-equatable-fields'),
       );
     });
 

test/src/config_builder/analysis_options_utils_test.dart

@@ -45,7 +45,7 @@ const _merged = {
 };
 
 void main() {
-  group('', () {
+  group('analysis_options_utils', () {
     test('isIterableOfStrings checks type of provided object', () {
       expect(isIterableOfStrings(null), isFalse);
       expect(isIterableOfStrings(Object()), isFalse);

tools/analyzer_plugin/pubspec.yaml

@@ -1,12 +1,12 @@
 name: dart_code_linter_plugin_loader
 description: This pubspec determines the version of the analyzer plugin to load.
-version: 1.1.2
+version: 1.1.3
 
 environment:
   sdk: ">=2.14.0 <3.0.0"
 
 dependencies:
-  dart_code_linter: 1.1.2
+  dart_code_linter: 1.1.3
 
 dev_dependencies:
   lints: ^1.0.1