#2771 - Expand Number of Days before Application Gets Archived #4375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh16011993
reviewed
Feb 21, 2025
| @oc process -f openshift/sysdig-team.yml -p LICENSE_PLATE=a6ef19 | oc apply -f - |
There was a problem hiding this comment.
I believe this change is showing because of the formatter.
sh16011993
approved these changes
Feb 21, 2025
dheepak-aot
reviewed
Feb 21, 2025
| @@ -80,7 +80,7 @@ env: | |||
| ATBC_LOGIN_ENDPOINT: ${{ secrets.ATBC_LOGIN_ENDPOINT }} | |||
| ATBC_ENDPOINT: ${{ secrets.ATBC_ENDPOINT }} | |||
| SWAGGER_ENABLED: true | |||
| APPLICATION_ARCHIVE_DAYS: 43 | |||
| APPLICATION_ARCHIVE_DAYS: ${{ vars.APPLICATION_ARCHIVE_DAYS }} | |||
dheepak-aot
reviewed
Feb 21, 2025
| @@ -11,7 +11,7 @@ BUILD_ID=0 | |||
| API_PORT=3000 | |||
| APP_PORT=8080 | |||
| SWAGGER_ENABLED=true | |||
| APPLICATION_ARCHIVE_DAYS=43 | |||
| APPLICATION_ARCHIVE_DAYS=365 | |||
There was a problem hiding this comment.
Can we also adjust E2E tests to use new value ?
This is as per following technical AC.
There was a problem hiding this comment.
Updated the test. Thanks!
|
Backend Unit Tests Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
E2E Workflow Workers Coverage Report
|
dheepak-aot
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
${{ vars.APPLICATION_ARCHIVE_DAYS }};