Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2771 - Expand Number of Days before Application Gets Archived #4375

Merged
merged 2 commits into from
Feb 21, 2025
Merged

#2771 - Expand Number of Days before Application Gets Archived #4375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
295cf84
initial commit
andrepestana-aot Feb 21, 2025
b8dadd8
updated tests
andrepestana-aot Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release-deploy-all.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ env:
ATBC_LOGIN_ENDPOINT: ${{ secrets.ATBC_LOGIN_ENDPOINT }}
ATBC_ENDPOINT: ${{ secrets.ATBC_ENDPOINT }}
SWAGGER_ENABLED: true
APPLICATION_ARCHIVE_DAYS: 43
APPLICATION_ARCHIVE_DAYS: ${{ vars.APPLICATION_ARCHIVE_DAYS }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

BYPASS_APPLICATION_SUBMIT_VALIDATIONS: ${{ secrets.BYPASS_APPLICATION_SUBMIT_VALIDATIONS }}
BYPASS_CRA_INCOME_VERIFICATION: ${{ secrets.BYPASS_CRA_INCOME_VERIFICATION }}
API_SECRET_NAME: ${{ secrets.OPENSHIFT_SIMS_CREDS_NAME }}
Expand Down
2 changes: 1 addition & 1 deletion configs/env-example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ BUILD_ID=0
API_PORT=3000
APP_PORT=8080
SWAGGER_ENABLED=true
APPLICATION_ARCHIVE_DAYS=43
APPLICATION_ARCHIVE_DAYS=365
Copy link
Collaborator

@dheepak-aot dheepak-aot Feb 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also adjust E2E tests to use new value ?

image

This is as per following technical AC.

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the test. Thanks!


# Database
POSTGRES_USER=
Expand Down
4 changes: 2 additions & 2 deletions devops/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export BYPASS_CRA_INCOME_VERIFICATION := $(or $(BYPASS_CRA_INCOME_VERIFICATION),
export IS_FULLTIME_ALLOWED := $(or $(IS_FULLTIME_ALLOWED), false)
export BYPASS_APPLICATION_SUBMIT_VALIDATIONS := $(or $(BYPASS_APPLICATION_SUBMIT_VALIDATIONS), false)
export SWAGGER_ENABLED := $(or ${SWAGGER_ENABLED}, true)
export APPLICATION_ARCHIVE_DAYS := $(or ${APPLICATION_ARCHIVE_DAYS}, 43)
export APPLICATION_ARCHIVE_DAYS := $(or ${APPLICATION_ARCHIVE_DAYS}, 365)
export REDIS_PORT := $(or ${REDIS_PORT}, 6379)
export CLAMAV_PORT := $(or ${CLAMAV_PORT}, 3310)
export API_PORT := $(or ${API_PORT}, 7070)
Expand Down Expand Up @@ -530,4 +530,4 @@ update-sysdig-team:
@oc process -f openshift/sysdig-team.yml -p LICENSE_PLATE=0c27fb | oc apply -f -
@echo "Updating Sysdig Team for license plate a6ef19.\n"
@oc project a6ef19-tools
@oc process -f openshift/sysdig-team.yml -p LICENSE_PLATE=a6ef19 | oc apply -f -
@oc process -f openshift/sysdig-team.yml -p LICENSE_PLATE=a6ef19 | oc apply -f -
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this change is showing because of the formatter.

2 changes: 1 addition & 1 deletion sources/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export IS_FULLTIME_ALLOWED := $(or $(IS_FULLTIME_ALLOWED), true)
export INSTITUTION_REQUEST_FOLDER := $(or $(INSTITUTION_REQUEST_FOLDER), OUT)
export INSTITUTION_RESPONSE_FOLDER := $(or $(INSTITUTION_RESPONSE_FOLDER), IN)
export SWAGGER_ENABLED := $(or ${SWAGGER_ENABLED}, true)
export APPLICATION_ARCHIVE_DAYS := $(or ${APPLICATION_ARCHIVE_DAYS}, 43)
export APPLICATION_ARCHIVE_DAYS := $(or ${APPLICATION_ARCHIVE_DAYS}, 365)
#Formio forms integration
export FORMIO_SOURCE_REPO_URL := $(or ${FORMIO_SOURCE_REPO_URL}, https://github.com/formio/formio.git)
export FORMIO_SOURCE_REPO_TAG := $(or ${FORMIO_SOURCE_REPO_TAG}, v4.3.0)
Expand Down
2 changes: 1 addition & 1 deletion ...ation/ecert-integration/_tests_/ecert-full-time-process-integration.scheduler.e2e-spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ describe(

beforeAll(async () => {
// Env variable required for querying the eligible e-Cert records.
process.env.APPLICATION_ARCHIVE_DAYS = "42";
process.env.APPLICATION_ARCHIVE_DAYS = "365";
const { nestApplication, dataSource, sshClientMock } =
await createTestingAppModule();
app = nestApplication;
Expand Down
2 changes: 1 addition & 1 deletion ...ation/ecert-integration/_tests_/ecert-part-time-process-integration.scheduler.e2e-spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ describe(

beforeAll(async () => {
// Env variable required for querying the eligible e-Cert records.
process.env.APPLICATION_ARCHIVE_DAYS = "42";
process.env.APPLICATION_ARCHIVE_DAYS = "365";
const { nestApplication, dataSource, sshClientMock } =
await createTestingAppModule();
app = nestApplication;
Expand Down
Loading