Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host - UI: item placement #470

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Host - UI: item placement #470

merged 2 commits into from
Jan 17, 2025

Conversation

deetz99
Copy link
Collaborator

@deetz99 deetz99 commented Jan 16, 2025

Issue:

Description of changes:

  • move checklist inside doc upload card
  • add text above bl input
  • update label for number of rooms
  • fix icon sizing on mobile

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-hosts-dev--pr-470-id90xa4e.web.app

1 similar comment
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-hosts-dev--pr-470-id90xa4e.web.app

Copy link
Collaborator

@kialj876 kialj876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - one question that isn't a show stopper

@@ -168,6 +169,9 @@ onMounted(async () => {
:state="propStore.blInfo"
>
<div class="space-y-10 py-10">
<p class="px-4 md:px-10">
{{ $t('text.ifYouHaveBl') }}
</p>
<ConnectFormSection
:title="$t('label.localGovBL')"
:error="isComplete && hasFormErrors(blFormRef, ['businessLicense', 'businessLicenseExpiryDate'])"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these be required when bl document is required? Right now I think they are always optional?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requirement was to have them be always optional, confirmed with Stefanie awhile ago.

@deetz99 deetz99 merged commit 39d1a35 into bcgov:main Jan 17, 2025
25 checks passed
@deetz99 deetz99 deleted the host-updates branch January 17, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants