Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host - UI: item placement #470

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Host - UI: item placement #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
777a01c
placement
deetz99 Jan 16, 2025
66d63a7
bump version
deetz99 Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions strr-base-web/app/components/connect/checklist/Validated.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,12 @@ const checklistItemId = `-connect-requirement-checklist-item-${listId}`
<UIcon
v-if="item.isValid"
:name="item.validIcon || 'i-mdi-check'"
:class="item.validIconClass || 'size-5 text-green-600'"
:class="item.validIconClass || 'size-5 text-green-600 shrink-0 self-start'"
/>
<UIcon
v-else-if="!item.isValid && isComplete"
:name="item.invalidIcon || 'i-mdi-close'"
:class="item.invalidIconClass || 'mt-[2px] size-5 text-red-600'"
:class="item.invalidIconClass || 'mt-[2px] size-5 text-red-600 shrink-0 self-start'"
/>
<span aria-hidden="true">{{ item.label }}</span>
</li>
Expand Down
32 changes: 18 additions & 14 deletions strr-host-pm-web/app/components/form/AddDocuments/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,21 +77,22 @@ onMounted(async () => {
v-if="docStore.requiredDocs.length > 0 || reqStore.overrideApplicationWarning"
class="flex flex-col gap-10"
>
<ConnectChecklistValidated
v-if="!reqStore.overrideApplicationWarning"
data-testid="required-docs-checklist"
:is-complete="isComplete"
:title="$t('text.followingDocsRequired')"
:items="docStore.requiredDocs"
/>
<ConnectChecklistBasic
v-else
data-testid="potential-docs-checklist"
:title="$t('text.followingDocsMayBeRequired')"
:items="docStore.potentialRequiredDocs"
/>

<ConnectPageSection :aria-label="$t('text.uploadReqDocs')">
<div class="px-4 pt-10 md:px-10">
<ConnectChecklistValidated
v-if="!reqStore.overrideApplicationWarning"
data-testid="required-docs-checklist"
:is-complete="isComplete"
:title="$t('text.followingDocsRequired')"
:items="docStore.requiredDocs"
/>
<ConnectChecklistBasic
v-else
data-testid="potential-docs-checklist"
:title="$t('text.followingDocsMayBeRequired')"
:items="docStore.potentialRequiredDocs"
/>
</div>
<UForm
ref="docFormRef"
:state="docStore.requiredDocs"
Expand Down Expand Up @@ -168,6 +169,9 @@ onMounted(async () => {
:state="propStore.blInfo"
>
<div class="space-y-10 py-10">
<p class="px-4 md:px-10">
{{ $t('text.ifYouHaveBl') }}
</p>
<ConnectFormSection
:title="$t('label.localGovBL')"
:error="isComplete && hasFormErrors(blFormRef, ['businessLicense', 'businessLicenseExpiryDate'])"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these be required when bl document is required? Right now I think they are always optional?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requirement was to have them be always optional, confirmed with Stefanie awhile ago.

Expand Down
4 changes: 2 additions & 2 deletions strr-host-pm-web/app/components/form/AddOwners/Index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@ const checklistItems = computed<ConnectValidatedChecklistItem[]>(() => [
label: t('strr.text.includeCohost'),
isValid: hasCoHost.value,
invalidIcon: 'i-mdi-information-outline',
invalidIconClass: 'mt-[2px] size-5 text-blue-500'
invalidIconClass: 'mt-[2px] size-5 text-blue-500 shrink-0 self-start'
},
{
label: t('strr.text.includePropertyManager'),
isValid: hasPropertyManager.value,
invalidIcon: 'i-mdi-information-outline',
invalidIconClass: 'mt-[2px] size-5 text-blue-500'
invalidIconClass: 'mt-[2px] size-5 text-blue-500 shrink-0 self-start'
}
])

Expand Down
5 changes: 3 additions & 2 deletions strr-host-pm-web/app/locales/en-CA.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ export default {
contactIndName: "Contact Individual's Name",
individualsBusinesses: 'Individuals and Businesses',
listingLinkOpt: 'Listing Link (Optional)',
numberOfRooms: 'Number of Rooms for Rent',
numberOfRooms: 'Number of Bedrooms for Rent',
ownershipType: 'Ownership Type',
nicknameOpt: 'Nickname (Optional)',
parcelIdentifier: 'Parcel Identifier',
Expand Down Expand Up @@ -361,7 +361,8 @@ export default {
unitAddressUnitNumberInfo: 'Unit Number is required if the short-term rental unit has a Unit Number. Enter a Site Name if the address does not have a Street Number and Name.',
noDocsUploaded: 'No supporting documentation uploaded.',
bceidSubtext: 'Requires an existing BCeID login account',
noIndividualsOrBusinesses: 'You don’t have any individuals or businesses listed yet. Select “Add an individual” or “Add a business” above.'
noIndividualsOrBusinesses: 'You don’t have any individuals or businesses listed yet. Select “Add an individual” or “Add a business” above.',
ifYouHaveBl: 'If you have a business licence for your short-term rental, add your information here.'
},
hint: {
strataRefCode: 'This is a unique code for each registered strata hotel. Ask the strata hotel management for this code.',
Expand Down
2 changes: 1 addition & 1 deletion strr-host-pm-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "strr-host-pm-web",
"private": true,
"type": "module",
"version": "0.0.40",
"version": "0.0.41",
"scripts": {
"build-check": "nuxt build",
"build": "nuxt generate",
Expand Down
Loading