23353 POC for new continuation in design #734

severinbeauvais · 2024-09-23T16:41:13Z

NOTE: merging this PR will BREAK the current continuation in application functionality, but forthcoming tickets will update the flows/statuses and get things working again. Olga is OK with this.

Description of changes:

app version = 5.12.0
generalized page blurb functionality
always show fee summary
added special case for page header
added special case for fee summary label
added special route checks for continuation in authorization vs application
added special continuation in authorization steps
added special case for file and pay button label (submit vs resubmit)
added special cases for validation in file and pay method
added special case for no payment
reverted Effective Date Time radio labels
updated file upload error messages
renamed ContinuationInBusinessHome -> ContinuationInAuthorizationPage
added file name validation for ISO-8859-1 encoding
renamed ContinuationAuthorization -> AuthorizationProof
added filename ISO8859-1 encoding check
updated misc existing business information layout, labels, etc
removed confirmation checkbox
cleaned up summary page
fixed alignment on summary page
renamed some getters
added special case for dialog filing title
renamed route + view + enums + getters + interfaces
added special case for no fee when restoring draft
added page blurbs to continuation in resource files
separated auth step from the rest
renumbered steps + hide stepper for step 0
deleted obsolete dissolution resource objects
added some store getters
added Authorization Contact Information to step 0 page
updated continuation in authorization page validation
added special case to show pages errors and scroll properly
removed draft-only checks on FED and staff payment components
updated/added unit tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

Sample Continuation Authorization ("step 0"):

bcregistry-sre · 2024-09-23T16:44:08Z

Temporary Url for review: https://business-create-dev--pr-734-k2qli397.web.app

SB says, try these:

draft continuation authorization: https://business-create-dev--pr-734-k2qli397.web.app/continuation-in-authorization?id=TZYacM9KPv
approved continuation application: https://business-create-dev--pr-734-k2qli397.web.app/continuation-in-business-bc?id=Tl4Z79Y9h4
sample incorporation application (for regression testing): https://business-create-dev--pr-734-k2qli397.web.app/incorporation-review-confirm?id=TB5sc8MzzJ
sample firm dissolution (for regression testing: https://business-create-dev--pr-734-k2qli397.web.app/dissolution-firm?id=FM1017608
sample voluntary dissolution (for regression testing): https://business-create-dev--pr-734-k2qli397.web.app/dissolution-define-dissolution?id=CP1002597

severinbeauvais · 2024-09-23T21:20:39Z

tests/unit/Actions.spec.ts

    const localVue = createLocalVue()
    localVue.use(VueRouter)
    const router = mockRouter.mock()
    router.push({ name: 'continuation-in-review-confirm', query: { id: 'T1234567' } })
    const wrapper = shallowMount(Actions, {
      // declare computed properties to override local and store getters:
      computed: {
+        isContinuationInFiling: () => true,


This is an easy way to override a store getter.

severinbeauvais · 2024-09-25T16:42:49Z

src/resources/ContinuationIn/C.ts

@@ -12,10 +12,11 @@ export const ContinuationInResourceC: ContinuationInResourceIF = {
    entityType: CorpTypeCd.CONTINUE_IN,
    filingTypeCode: FilingCodes.CONTINUATION_IN
  }],
+  pageBlurbDraft: `To continue in to B.C., you must first submit a Continuation Authorization and
+    have it approved by BC Registries before filing a Continuation Application.`,


See App.vue line 170 and store.ts line 1108 for generalized page blurb functionality.

(Also applies to GP and SP, below.)

severinbeauvais · 2024-09-25T16:43:33Z

src/resources/Dissolution/GP.ts

-        }
-      ],
-      items: []
-    }


^^ Unused code. Must have come from initial copy-paste when implementing firm dissolution.

- generalized page blurb functionality - always show fee summary - added special case for page header - added special case for fee summary label - added special route checks for continuation in authorization vs application - added special continuation in authorization steps - added special case for file and pay button label (submit vs resubmit) - added special cases for validation in file and pay method - added special case for no payment - reverted Effective Date Time radio labels - updated file upload error messages - renamed ContinuationInBusinessHome -> ContinuationInAuthorizationPage - added file name validation for ISO-8859-1 encoding - renamed ContinuationAuthorization -> AuthorizationProof - added filename ISO8859-1 encoding check - updated misc existing business information layout, labels, etc - removed confirmation checkbox - cleaned up summary page - fixed alignment on summary page - renamed some getters - added special case for dialog filing title - renamed route + view + enums + getters + interfaces - added special case for no fee when restoring draft - added page blurbs to continuation in resource files - separated auth step from the rest - renumbered steps + hide stepper for step 0 - deleted obsolete dissolution resource objects - added some store getters - added Authorization Contact Information to step 0 page - updated continuation in authorization page validation - added special case to show pages errors and scroll properly - removed draft-only checks on FED and staff payment components - updated/added unit tests

severinbeauvais · 2024-10-01T18:55:32Z

src/App.vue

+    // *** TODO: remove after testing
+    if (draftFiling.header.status === FilingStatus.CHANGE_REQUESTED) {
+      this.setFilingStatus(FilingStatus.APPROVED)
+    }


This is a temporary override for testing. This PR breaks this filing in other ways so I think this is OK to merge into main branch (Dev, etc).

("Change Requested" is only used for continuation in applications, which isn't released to Prod yet, so this change should not affect anything else.)

severinbeauvais · 2024-10-01T18:59:55Z

src/components/ContinuationIn/AuthorizationProof.vue

+    function isValidLatin1 (str: string): boolean {
+      // eslint-disable-next-line no-control-regex
+      return !/[^\u0000-\u00ff]/g.test(str)
+    }


I did a bit of research on how to identify filenames with invalid characters and this is the best / cleanest I could find. (Other solutions used libraries or packages and made other assumptions.)

This arose from a file that Janis was trying to upload and which caused an error while trying to upload the file. Now the following error is displayed:

Update: I can't upload a sample file with the invalid filename for you to try because GH fixes it.

severinbeauvais · 2024-10-01T19:08:49Z

src/components/ContinuationIn/SummaryBusinessHomeJurisdiction.vue

            >
              <!-- the director's affidavit file -->
              <template v-if="isContinuationInAffidavitRequired">
                <v-btn
                  v-if="getExistingBusinessInfo.affidavitFileName"
                  text
                  color="primary"
-                  class="download-affidavit-btn mt-sm-n2 d-block"
+                  class="download-affidavit-btn mt-sm-n2 d-block px-2 ml-n2"


This and above : fixed alignment, ie

Now the button text appears to line up with other content in this column, but the button still has horizontal padding.

severinbeauvais · 2024-10-01T19:12:26Z

src/views/ContinuationIn/ContinuationInReviewConfirm.vue

@@ -73,7 +73,6 @@

    <!-- Continuation Effective Date and Time -->
    <section
-      v-if="(getFilingStatus === FilingStatus.DRAFT) || getEffectiveDateTime.isFutureEffective"


Previously we hid some sections if this was a Draft. Now, draft applications only see "step 0". In other states, we can show these sections normally.

severinbeauvais · 2024-10-01T19:53:55Z

/gcbrun

bcregistry-sre · 2024-10-01T19:57:17Z

Temporary Url for review: https://business-create-dev--pr-734-k2qli397.web.app

severinbeauvais · 2024-10-01T21:03:57Z

tests/unit/ContinuationInAuthorization.spec.ts

This is not a new file. It was previously named "tests/unit/ContinuationInBusinessHome.spec.ts". I don't know why GH isn't recognizing that.

severinbeauvais · 2024-10-01T22:01:29Z

If you have any further comments on this PR, I will fix them as part of bcgov/entity#23514.

severinbeauvais added the DO NOT MERGE label Sep 23, 2024

severinbeauvais self-assigned this Sep 23, 2024

severinbeauvais commented Sep 23, 2024

View reviewed changes

severinbeauvais force-pushed the 23353 branch from cd39947 to 9ab954a Compare September 23, 2024 23:29

bcgov deleted a comment from bcregistry-sre Sep 23, 2024

bcgov deleted a comment from bcregistry-sre Sep 24, 2024

severinbeauvais force-pushed the 23353 branch 2 times, most recently from d5905f1 to 0f6b331 Compare September 24, 2024 23:30

bcgov deleted a comment from bcregistry-sre Sep 24, 2024

severinbeauvais commented Sep 25, 2024

View reviewed changes

bcgov deleted a comment from bcregistry-sre Sep 25, 2024

bcgov deleted a comment from bcregistry-sre Sep 26, 2024

severinbeauvais force-pushed the 23353 branch from 70b9f64 to 422083f Compare September 26, 2024 17:03

bcgov deleted a comment from bcregistry-sre Sep 26, 2024

severinbeauvais mentioned this pull request Sep 26, 2024

POC: determine complexity of Create UI changes to support new Continuation In design bcgov/entity#23353

Closed

severinbeauvais force-pushed the 23353 branch 2 times, most recently from fd9f9e7 to c5ca782 Compare October 1, 2024 17:50

severinbeauvais force-pushed the 23353 branch from c5ca782 to 83021f0 Compare October 1, 2024 18:47

severinbeauvais requested review from JazzarKarim, ketaki-deodhar, ArwenQin and vysakh-menon-aot October 1, 2024 18:48

- temporary status override bypass for testing

a2dc013

bcgov deleted a comment from bcregistry-sre Oct 1, 2024

severinbeauvais commented Oct 1, 2024

View reviewed changes

bcgov deleted a comment from bcregistry-sre Oct 1, 2024

- improved button layout

840e253

severinbeauvais commented Oct 1, 2024

View reviewed changes

severinbeauvais removed the DO NOT MERGE label Oct 1, 2024

severinbeauvais marked this pull request as ready for review October 1, 2024 19:12

severinbeauvais commented Oct 1, 2024

View reviewed changes

vysakh-menon-aot approved these changes Oct 1, 2024

View reviewed changes

severinbeauvais merged commit b841af3 into bcgov:main Oct 1, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

23353 POC for new continuation in design #734

23353 POC for new continuation in design #734

severinbeauvais commented Sep 23, 2024 •

edited

Loading

bcregistry-sre commented Sep 23, 2024 •

edited by severinbeauvais

Loading

severinbeauvais Sep 23, 2024

severinbeauvais Sep 25, 2024 •

edited

Loading

severinbeauvais Sep 25, 2024

severinbeauvais Oct 1, 2024

severinbeauvais Oct 1, 2024 •

edited

Loading

severinbeauvais Oct 1, 2024 •

edited

Loading

severinbeauvais Oct 1, 2024

severinbeauvais commented Oct 1, 2024

bcregistry-sre commented Oct 1, 2024

severinbeauvais Oct 1, 2024

severinbeauvais commented Oct 1, 2024

23353 POC for new continuation in design #734

23353 POC for new continuation in design #734

Conversation

severinbeauvais commented Sep 23, 2024 • edited Loading

bcregistry-sre commented Sep 23, 2024 • edited by severinbeauvais Loading

severinbeauvais Sep 23, 2024

Choose a reason for hiding this comment

severinbeauvais Sep 25, 2024 • edited Loading

Choose a reason for hiding this comment

severinbeauvais Sep 25, 2024

Choose a reason for hiding this comment

severinbeauvais Oct 1, 2024

Choose a reason for hiding this comment

severinbeauvais Oct 1, 2024 • edited Loading

Choose a reason for hiding this comment

severinbeauvais Oct 1, 2024 • edited Loading

Choose a reason for hiding this comment

severinbeauvais Oct 1, 2024

Choose a reason for hiding this comment

severinbeauvais commented Oct 1, 2024

bcregistry-sre commented Oct 1, 2024

severinbeauvais Oct 1, 2024

Choose a reason for hiding this comment

severinbeauvais commented Oct 1, 2024

severinbeauvais commented Sep 23, 2024 •

edited

Loading

bcregistry-sre commented Sep 23, 2024 •

edited by severinbeauvais

Loading

severinbeauvais Sep 25, 2024 •

edited

Loading

severinbeauvais Oct 1, 2024 •

edited

Loading

severinbeauvais Oct 1, 2024 •

edited

Loading