15538 Fixed court order type not being restored #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added court order initial case - fixed registrar initial case - fixed lint warning
|
/gcbrun |
|
Temporary Url for review: https://business-create-dev--pr-736-9p7t2cem.web.app SB says, try this: https://business-create-dev--pr-736-9p7t2cem.web.app/restoration-business-name?id=BC0872082 |
severinbeauvais
requested review from
vysakh-menon-aot,
ketaki-deodhar and
ArwenQin
severinbeauvais
commented
Sep 25, 2024
| @@ -3,6 +3,7 @@ | |||
| <ApprovalTypeShared | |||
| class="pa-8" | |||
| :courtOrderNumber="getRestoration.courtOrder.fileNumber" | |||
| :approvedByCourtOrder="approvedByCourtOrder" | |||
There was a problem hiding this comment.
This is needed to set the initial state of the (shared) ApprovalType component. Without this, the court order option (and its value) were not being restored/displayed.
severinbeauvais
commented
Sep 25, 2024
| get approvedByRegistrar (): boolean { | ||
| return (!!this.getRestoration.noticeDate && !!this.getRestoration.applicationDate) | ||
| return (!!this.getRestoration.noticeDate || !!this.getRestoration.applicationDate) |
There was a problem hiding this comment.
Bugfix: show this option if either date was entered.
vysakh-menon-aot
approved these changes
Sep 25, 2024
ketaki-deodhar
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#15538
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).