Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15538 Fixed court order type not being restored #736

Merged
merged 1 commit into from
Sep 25, 2024
Merged

15538 Fixed court order type not being restored #736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-create-ui",
"version": "5.11.20",
"version": "5.11.21",
"private": true,
"appName": "Create UI",
"sbcName": "SBC Common Components",
Expand Down
7 changes: 6 additions & 1 deletion src/components/Restoration/ApprovalType.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<ApprovalTypeShared
class="pa-8"
:courtOrderNumber="getRestoration.courtOrder.fileNumber"
:approvedByCourtOrder="approvedByCourtOrder"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed to set the initial state of the (shared) ApprovalType component. Without this, the court order option (and its value) were not being restored/displayed.

:approvedByRegistrar="approvedByRegistrar"
:noticeDate="getRestoration.noticeDate"
:applicationDate="getRestoration.applicationDate"
Expand Down Expand Up @@ -44,8 +45,12 @@ export default class ApprovalType extends Vue {
@Action(useStore) setRestorationCourtOrder!: (x: CourtOrderIF) => void
@Action(useStore) setRestorationNoticeDate!: (x: string) => void

get approvedByCourtOrder (): boolean {
return !!this.getRestoration.courtOrder.fileNumber
}

get approvedByRegistrar (): boolean {
return (!!this.getRestoration.noticeDate && !!this.getRestoration.applicationDate)
return (!!this.getRestoration.noticeDate || !!this.getRestoration.applicationDate)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugfix: show this option if either date was entered.

}
}
</script>
2 changes: 1 addition & 1 deletion src/views/Restoration/RestorationBusinessName.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<h2>Restoration Type</h2>
<p class="pt-2">
Determine the restoration and approval type.
</p>
</p>
</header>
<v-card
flat
Expand Down
Loading