Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 1634 & 1640 A few bug fixes #1673

Merged
merged 12 commits into from
Nov 18, 2024
Merged

fix: 1634 & 1640 A few bug fixes #1673

merged 12 commits into from
Nov 18, 2024

Conversation

xiaopeng0202
Copy link
Collaborator

@xiaopeng0202 xiaopeng0202 commented Oct 15, 2024 •
edited by github-actions bot
Loading

Description

Closes #1634 #1640

Changelog

  • adjust logic to render parent tree when adding the second orchard without further seting
  • set clientAndCodeInput checkbox unchecked as default for a few components
  • update a few wordings

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@xiaopeng0202 xiaopeng0202 changed the title 1634 & 1640 A few bug fixes fix: 1634 & 1640 A few bug fixes Oct 15, 2024
mgaseta
mgaseta requested changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The orchard behavior seems correct, but the checkbox behavior doesn't, although the checkbox is correctly unchecked, the input for agency acronym is disabled...

@xiaopeng0202
Copy link
Collaborator Author

The orchard behavior seems correct, but the checkbox behavior doesn't, although the checkbox is correctly unchecked, the input for agency acronym is disabled...

thanks for the finding! made an update

@mgaseta mgaseta self-requested a review October 24, 2024 14:16
@SLDonnelly SLDonnelly closed this Oct 29, 2024
@SLDonnelly SLDonnelly reopened this Oct 29, 2024
@xiaopeng0202 xiaopeng0202 reopened this Nov 15, 2024
@xiaopeng0202 xiaopeng0202 reopened this Nov 18, 2024
mgaseta
mgaseta approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

frontend/src/components/ClientAndCodeInput/index.tsx Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@xiaopeng0202 xiaopeng0202 enabled auto-merge (squash) November 18, 2024 23:41
@xiaopeng0202 xiaopeng0202 merged commit 7367346 into main Nov 18, 2024
24 of 25 checks passed
@xiaopeng0202 xiaopeng0202 deleted the feat/1640-undefault-checkbox branch November 18, 2024 23:51
@mgaseta mgaseta restored the feat/1640-undefault-checkbox branch November 20, 2024 15:30
mgaseta added a commit that referenced this pull request Nov 20, 2024
@mgaseta
Revert "fix: 1634 & 1640 A few bug fixes (#1673)"
2acde10 
This reverts commit 7367346.
@mgaseta mgaseta deleted the feat/1640-undefault-checkbox branch November 20, 2024 15:32
@mgaseta mgaseta mentioned this pull request Nov 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgaseta mgaseta mgaseta approved these changes

@RMCampos RMCampos Awaiting requested review from RMCampos

@DerekRoberts DerekRoberts Awaiting requested review from DerekRoberts DerekRoberts is a code owner

@SLDonnelly SLDonnelly Awaiting requested review from SLDonnelly SLDonnelly is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird behavior when setting secondary orchard
3 participants
@xiaopeng0202 @mgaseta @SLDonnelly