Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Include _data from theme in sites that use the theme #72

Closed
wants to merge 2 commits into from
Closed

WIP: Include _data from theme in sites that use the theme #72

wants to merge 2 commits into from

Conversation

delisma
Copy link

@delisma delisma commented Feb 12, 2020


name: Include _data from theme in sites that use the theme
about: #68
labels: help wanted, good first issue
assignees: @delisma

Is your feature request related to a problem? Please describe the problem you're trying to solve.

This feature could be useful for i18n and/or l10n, when building multilingual theme and the 118n strings sits in _data folder. In case of conflicts the files in _data can always be overridden like the _includes and _laytouts folders are.

Describe the solution you'd like

Modification of the munger_spec.rb to allow files in _data to be called by the theme

@delisma delisma changed the title feat: Include _data from theme in sites that use the theme WIP: Include _data from theme in sites that use the theme Feb 12, 2020
@stale
Copy link

stale bot commented Apr 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 12, 2020
@stale stale bot closed this Apr 19, 2020
@datapolitical
Copy link

I’d like to fork this repo and modify it to work with my custom theme’s additional folders, but I don’t understand which files to modify.

what’s the difference between the spec folder and the lib folder? It looks like I should modify the same folder you did, I just don’t really understand how the plugin is laid out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants