Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate GoodJob::Job#recent_error #1526

Merged

Conversation

Wittiest
Copy link
Contributor

Merge Notes

#1525 removes the only remaining usage of #recent_error in good_job

Details

Change made based on discussion in #1518:

I think recent_error is vestigial of GoodJob <v4 and should be deprecated and aliased to error. It used to be necessary because a Job was simply the most recent Execution but that's no longer the case and previous error from a job is not cleared when the job is re-executed.

Screenshot

Screenshot 2024-10-17 at 9 17 00 PM

@bensheldon bensheldon added the refactor Code changes that do not introduce new features label Oct 23, 2024
@bensheldon bensheldon merged commit 1cf9b07 into bensheldon:main Oct 23, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code changes that do not introduce new features
Projects
Development

Successfully merging this pull request may close these issues.

2 participants