Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scheduling): expose Strategy class #3993

Closed
wants to merge 1 commit into from
Closed

fix(scheduling): expose Strategy class #3993

wants to merge 1 commit into from

Conversation

bojiang
Copy link
Member

@bojiang bojiang commented Jun 26, 2023

No description provided.

@bojiang bojiang requested a review from a team as a code owner June 26, 2023 08:21
@bojiang bojiang requested review from sauyon and removed request for a team June 26, 2023 08:21
@aarnphm
Copy link
Contributor

aarnphm commented Jun 26, 2023

Hmm can you run pre-commit run --all-files again? I thought we set our import lines to be single lines 🤔

@bojiang
Copy link
Member Author

bojiang commented Jun 26, 2023 •
edited
Loading

@aarnphm Tried. Nothing changes.
I've upgraded black to the newest version.

@aarnphm
Copy link
Contributor

aarnphm commented Jun 26, 2023

hmm this is weird

@frostming frostming mentioned this pull request Jun 28, 2023
Closed
@aarnphm
Copy link
Contributor

aarnphm commented Jul 11, 2023

cc @bojiang please update this with the merge conflict.

@aarnphm aarnphm mentioned this pull request Jul 20, 2023
Merged
5 tasks
@aarnphm
Copy link
Contributor

aarnphm commented Jul 20, 2023

In light of #4068

@aarnphm aarnphm closed this Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sauyon sauyon Awaiting requested review from sauyon sauyon is a code owner automatically assigned from bentoml/bentoml-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bojiang @aarnphm