ci: Sort imports with isort #4003
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frost Ming <[email protected]>
frostming
requested review from
larme and
bojiang
and removed request for
a team
aarnphm
reviewed
Jun 28, 2023
Codecov Report
@@ Coverage Diff @@
## main #4003 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 166 166
Lines 15286 15290 +4
=====================================
- Misses 15286 15290 +4
|
|
@frostming we need to do this https://beta.ruff.rs/docs/settings/#select [tool.ruff]
extend-select = ["I"]See the list of linter with |
Yeah, that works! See #4032 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Frost Ming [email protected]
What does this PR address?
Introduce isort as the formatter to fix the issue that ruff doesn't sort imports correctly(#3993)