Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add isort to the ruff lint rules #4032

Merged
merged 2 commits into from
Jul 11, 2023
Merged

ci: add isort to the ruff lint rules #4032

merged 2 commits into from
Jul 11, 2023

Conversation

frostming
Copy link
Contributor

@frostming frostming commented Jul 10, 2023 •
edited
Loading

Signed-off-by: Frost Ming [email protected]

What does this PR address?

Adding extend-select actually makes it work!
But since ruff doesn't support sort imports by length, changes are expected.

Supersedes #4003

@aarnphm

@frostming frostming requested a review from a team as a code owner July 10, 2023 10:38
@frostming frostming requested review from parano and removed request for a team July 10, 2023 10:38
@frostming frostming mentioned this pull request Jul 10, 2023
Closed
aarnphm
aarnphm previously approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the changes for diffusers here as well?

@aarnphm
fix: address comments
e15ca12 
Signed-off-by: aarnphm-ec2-dev <[email protected]>
@aarnphm aarnphm merged commit 79b10e9 into bentoml:main Jul 11, 2023
@frostming frostming deleted the fix/ruff-isort branch July 11, 2023 00:43
@jerryharrow jerryharrow mentioned this pull request Nov 2, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarnphm aarnphm aarnphm approved these changes

@parano parano Awaiting requested review from parano parano is a code owner automatically assigned from bentoml/bentoml-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frostming @aarnphm