Allow Image to be created without data
#17746
Labels
A-Rendering
Drawing game state to the screen
C-Feature
A new feature, making something new possible
D-Modest
A "normal" level of difficulty; suitable for simple features or challenging fixes
Comments
tychedelia
added
A-Rendering
github-merge-queue bot
pushed a commit
that referenced
this issue
Feb 10, 2025
…17760) # Objective #17746 ## Solution - Change `Image.data` from being a `Vec<u8>` to a `Option<Vec<u8>>` - Added functions to help with creating images ## Testing - Did you test these changes? If so, how? All current tests pass Tested a variety of existing examples to make sure they don't crash (they don't) - If relevant, what platforms did you test these changes on, and are there any important ones you can't test? Linux x86 64-bit NixOS --- ## Migration Guide Code that directly access `Image` data will now need to use unwrap or handle the case where no data is provided. Behaviour of new_fill slightly changed, but not in a way that is likely to affect anything. It no longer panics and will fill the whole texture instead of leaving black pixels if the data provided is not a nice factor of the size of the image. --------- Co-authored-by: IceSentry <[email protected]>
|
this can probably be closed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What problem does this solve or what need does it fill?
Currently, the
RenderAssetimplementation forGpuImageunconditionally callscreate_texture_with_data.This is unhelpful for creating textures that are intended to be filled in on the GPU, for example during a compute pass that runs prior to rendering.What solution would you like?
ShaderStorageBuffferalready has a similar solution where different constructors are provided with/without data. Do the same forImageand determine whether we need to create a texture with data based on the presence of data inImage.The text was updated successfully, but these errors were encountered: