Entities that should be visible are being culled #17759
Labels
A-Rendering
Drawing game state to the screen
C-Bug
An unexpected or incorrect behavior
S-Needs-Triage
This issue needs to be labelled
Comments
superdump
added
C-Bug
|
This is even more apparent for me in debug mode.
It seems to bisect to 7fc122a |
pcwalton
added a commit
to pcwalton/bevy
that referenced
this issue
Feb 10, 2025
Currently, we *sweep*, or remove entities from bins when those entities became invisible or changed phases, during `queue_material_meshes` and similar phases. This, however, is wrong, because `queue_material_meshes` executes once per material type, not once per phase. This could result in sweeping bins multiple times per phase, which can corrupt the bins. This commit fixes the issue by moving sweeping to a separate system that runs after queuing. This manifested itself as entities appearing and disappearing seemingly at random. Closes bevyengine#17759.
github-merge-queue bot
pushed a commit
that referenced
this issue
Feb 10, 2025
Currently, we *sweep*, or remove entities from bins when those entities became invisible or changed phases, during `queue_material_meshes` and similar phases. This, however, is wrong, because `queue_material_meshes` executes once per material type, not once per phase. This could result in sweeping bins multiple times per phase, which can corrupt the bins. This commit fixes the issue by moving sweeping to a separate system that runs after queuing. This manifested itself as entities appearing and disappearing seemingly at random. Closes #17759. --------- Co-authored-by: Robert Swain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bevy version
main @
556b75078288464e9628d3e939afdedfea34e958[Optional] Relevant system information
What you did
Run
cargo run --release --example many_cubesWhat went wrong
Expected: all cubes that should be visible are visible in every frame
Observed: some cubes are not visible when they should be.
Additional information
As they are only missing for a few frames it is difficult to take a screenshot but here is a short screen capture where the missing cubes can be seen as they come into view from the top of the frame.
2025-02-09.at.15.44.49.-.Broken.culling.H264.mp4
The text was updated successfully, but these errors were encountered: