Limit the maximum zoom level #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BigBlueButton client (in current versions) doesn't allow zooming in further than 400% (i.e. 1/4 of document width). However, there are occasionally glitches which can cause a higher zoom level to be reported. Sometimes *extremely* high (an issue was reported where the events.xml `<widthRatio>` was 0.06944444444444445 - that corresponds to a zoom level of 144000%). This can cause issues in the rendering. For example, if a shape with text is being drawn, the required font size might exceed the maximum limits of the freetype text rasterizer. (With newer versions of cairo, this error is recoverable, but with older versions like used on Ubuntu 20.04 the error will crash the video generation tool.) Apply a safety limit on the zoom level so that it does not exceed 800% (i.e. 1/16 of document width).
antobinary
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BigBlueButton client (in current versions) doesn't allow zooming in further than 400% (i.e. 1/4 of document width). However, there are occasionally glitches which can cause a higher zoom level to be reported
<widthRatio>was 0.06944444444444445 - that corresponds to a zoom level of 144000%).This can cause issues in the rendering. For example, if a shape with text is being drawn, the required font size might exceed the maximum limits of the freetype text rasterizer. (With newer versions of cairo, this error is recoverable, but with older versions like used on Ubuntu 20.04 the error will crash the video generation tool.)
Apply a safety limit on the zoom level so that it does not exceed 800% (i.e. 1/16 of document width).