Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the maximum zoom level #56

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Limit the maximum zoom level #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions bbb_presentation_video/events/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,16 +131,26 @@ def parse_pan_zoom(

width_ratio = xml_subelement(element, name, "widthRatio")
height_ratio = xml_subelement(element, name, "heightRatio")

# Some BBB versions can produce invalid NaN ratios which can't be parsed as floats
if width_ratio == "NaN" or height_ratio == "NaN":
event["zoom"] = Size(1.0, 1.0)
else:
event["zoom"] = Size(float(width_ratio) / 100, float(height_ratio) / 100)

# Workaround a bug where BBB can return a width or height ratio of 0,
# which is nonsensical and causes divide-by-zero errors.
# It can also return values less than zero, I dunno what's up with that.
if event["zoom"].width <= 0 or event["zoom"].height <= 0:
event["zoom"] = Size(1.0, 1.0)

# The max zoom permitted in the BBB client is 400% (i.e. show 1/4 of the width of the slide)
# Apply a hard limit at 800% to prevent processing errors
if event["zoom"].width < 0.125:
event["zoom"] = Size(
0.125, event["zoom"].height * (0.125 / event["zoom"].height)
)

pod_id = xml_subelement_opt(element, "podId")
event["pod_id"] = pod_id if pod_id is not None else DEFAULT_PRESENTATION_POD

Expand Down
Loading