add get deposit histoty and get withdraw history #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da8865892q
reviewed
Jul 10, 2023
v3-1/rest-1/rest.md
Outdated
| @@ -73,4 +73,6 @@ | |||
| | [Get an order](auth/get-order.md) | `GET` /orders/{pair}/{orderId} | [https://api.bitopro.com/v3/orders/bito\_twd/123456789](https://api.bitopro.com/v3/orders/bito_twd/123456789) | | |||
| | [Get Withdraw Information](auth/get-withdraw.md) | `GET` /wallet/withdraw/{currency}/{serial} | [https://api.bitopro.com/v3/wallet/withdraw/twd/123456](https://api.bitopro.com/v3/wallet/withdraw/123456) | | |||
| | [Withdraw](auth/withdraw.md) | `POST` /wallet/withdraw/{currency} | [https://api.bitopro.com/v3/wallet/withdraw/twd](https://api.bitopro.com/v3/wallet/withdraw/twd) | | |||
| | [Get-Deposit-History](auth/get-deposit-history.md) | `GET` /wallet/depositHistory/{currency} | [https://api.bitopro.com/v3/wallet/depositHistory/twd?startTimestamp=1615788459000&statuses=EMAIL_VERIFICATION](https://api.bitopro.com/v3/wallet/depositHistory/twd?startTimestamp=1615788459000&statuses=EMAIL_VERIFICATION) | | |||
There was a problem hiding this comment.
確認： Example 有需要給 startTimestamp 跟 statuses 嗎？ 因為這兩個都為非必填欄位。
建議：建議 Endpoint 格式盡量與其他 API 統一。
| [Get Deposit History Information](auth/get-deposit-history.md) | `GET` /wallet/depositHistory/{currency} | [https://api.bitopro.com/v3/wallet/depositHistory/twd](https://api.bitopro.com/v3/wallet/depositHistory/twd) |
下面那一行同理就不額外留言了。
da8865892q
reviewed
Jul 10, 2023
v3-1/rest-1/rest.md
Outdated
| @@ -73,4 +73,6 @@ | |||
| | [Get an order](auth/get-order.md) | `GET` /orders/{pair}/{orderId} | [https://api.bitopro.com/v3/orders/bito\_twd/123456789](https://api.bitopro.com/v3/orders/bito_twd/123456789) | | |||
| | [Get Withdraw Information](auth/get-withdraw.md) | `GET` /wallet/withdraw/{currency}/{serial} | [https://api.bitopro.com/v3/wallet/withdraw/twd/123456](https://api.bitopro.com/v3/wallet/withdraw/123456) | | |||
| | [Withdraw](auth/withdraw.md) | `POST` /wallet/withdraw/{currency} | [https://api.bitopro.com/v3/wallet/withdraw/twd](https://api.bitopro.com/v3/wallet/withdraw/twd) | | |||
| | [Get-Deposit-History](auth/get-deposit-history.md) | `GET` /wallet/depositHistory/{currency} | [https://api.bitopro.com/v3/wallet/depositHistory/twd](https://api.bitopro.com/v3/wallet/depositHistory/twd) | | |||
There was a problem hiding this comment.
建議：建議 Endpoint 格式盡量與其他 API 統一。 (第一次留言好像被遺漏了 XD)
| [Get Deposit History Information](auth/get-deposit-history.md) | `GET` /wallet/depositHistory/{currency} | [https://api.bitopro.com/v3/wallet/depositHistory/twd](https://api.bitopro.com/v3/wallet/depositHistory/twd) |
下面那一行同理就不額外留言了。 [Get Withdraw History Information]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.