Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add get deposit histoty and get withdraw history #42

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add get deposit histoty and get withdraw history #42

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d28de6
add get deposit histoty and get withdraw history
Jun 26, 2023
dce8525
fix api list example
Jul 10, 2023
8de4431
fix deposit and withdraw history endpoint name in rest.md
Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
.vscode
2 changes: 2 additions & 0 deletions v3-1/rest-1/rest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,6 @@
| [Get an order](auth/get-order.md) | `GET` /orders/{pair}/{orderId} | [https://api.bitopro.com/v3/orders/bito\_twd/123456789](https://api.bitopro.com/v3/orders/bito_twd/123456789) |
| [Get Withdraw Information](auth/get-withdraw.md) | `GET` /wallet/withdraw/{currency}/{serial} | [https://api.bitopro.com/v3/wallet/withdraw/twd/123456](https://api.bitopro.com/v3/wallet/withdraw/123456) |
| [Withdraw](auth/withdraw.md) | `POST` /wallet/withdraw/{currency} | [https://api.bitopro.com/v3/wallet/withdraw/twd](https://api.bitopro.com/v3/wallet/withdraw/twd) |
| [Get-Deposit-History](auth/get-deposit-history.md) | `GET` /wallet/depositHistory/{currency} | [https://api.bitopro.com/v3/wallet/depositHistory/twd](https://api.bitopro.com/v3/wallet/depositHistory/twd) |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建議：建議 Endpoint 格式盡量與其他 API 統一。 (第一次留言好像被遺漏了 XD)

| [Get Deposit History Information](auth/get-deposit-history.md) | `GET` /wallet/depositHistory/{currency} | [https://api.bitopro.com/v3/wallet/depositHistory/twd](https://api.bitopro.com/v3/wallet/depositHistory/twd) |

下面那一行同理就不額外留言了。 [Get Withdraw History Information]

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ciao

| [Get-Withdraw-History](auth/get-withdraw-history.md) | `GET` /wallet/withdrawHistory/{currency} | [https://api.bitopro.com/v3/wallet/withdrawHistory/twd](https://api.bitopro.com/v3/wallet/withdrawHistory/twd) |