Enum to categorize HybridFactor #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellaert
reviewed
Sep 17, 2024
gtsam/hybrid/HybridFactor.h
Outdated
| @@ -41,6 +41,9 @@ KeyVector CollectKeys(const KeyVector &keys1, const KeyVector &keys2); | |||
| DiscreteKeys CollectDiscreteKeys(const DiscreteKeys &key1, | |||
| const DiscreteKeys &key2); | |||
|
|
|||
| /// Enum to help with categorizing hybrid factors. | |||
| enum class HybridCategory { None, Discrete, Continuous, Hybrid }; | |||
There was a problem hiding this comment.
I like this a lot, but could we just make it an inner inside the HF class?
There was a problem hiding this comment.
Done. I renamed it to Category so it reads nicer as HybridFactor::Category.
dellaert
approved these changes
Sep 18, 2024
|
I was trying to avoid major merge conflicts. I guarantee you won't see this code in another review. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the previous boolean based checks for whether a
HybridFactorisDiscrete,ContinuousorHybridwith an enum.This would prevent a
HybridFactorfrom having multiple flags true accidentally.