-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bypass empty BU Text widgets in class count increment via filter #96
Open
alana29s
wants to merge
18
commits into
develop
Choose a base branch
from
45-empty-widget-count-expaned
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
97c4594
bypass empty BU Text widgets in class count via filter
alana29s 9abb02b
add filter to check for empty BU links widget.
alana29s 5e425e8
update change log
alana29s a45570d
include plugins directory for when not in admin area
alana29s f8c8f4c
add plugin paths to second filter
alana29s 295ed4b
fix trailing spaces
alana29s 400134b
coding standards fixes
alana29s 60cfaa6
update links widget empty check to include inheritance of widgets fro…
alana29s b207f8f
update text widget check for ancestors
alana29s 68a6e5d
clarify comments, remove unused $key variable,
alana29s c20989f
fix for empty parent with display on children true
alana29s 3a3440c
Merge branch 'develop' into 45-empty-widget-count-expaned
alana29s 2396552
Merge branch 'develop' into 45-empty-widget-count-expaned
alana29s 8b6b665
refactor for BU Text Reprint widget
alana29s eb1922e
refactor to include checks for BU Links Reprint widget
alana29s 95ce3c9
Merge branch 'develop' into 45-empty-widget-count-expaned
alana29s fdef0d2
Merge branch 'develop' into 45-empty-widget-count-expaned
ashleykolodziej 88e0b0f
Merge branch 'develop' into 45-empty-widget-count-expaned
ashleykolodziej File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to specify
$is_bu_widget_empty
, or do you think a generic name would be fine here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chose to be more generic there. The filter can be used for any type of widget, not just BU widgets.