Bypass empty BU Text widgets in class count increment via filter #96
Conversation
| * | ||
| * @params array $params An array of widget options. | ||
| */ | ||
| $is_widget_empty = apply_filters( 'responsive_is_widget_empty', $is_widget_empty = false, $params ); |
There was a problem hiding this comment.
Do we want to specify $is_bu_widget_empty, or do you think a generic name would be fine here?
There was a problem hiding this comment.
I chose to be more generic there. The filter can be used for any type of widget, not just BU widgets.
change long formatting
* develop: (1262 commits) Migrate Open PR #407 from 1x-develop Security Audit June 2018 (#106) Migrate Open PR #418 from 1x-develop fix deprecated GF call (#107) PHP Unit Testing Updates (#97) Run grunt build to complete version bump to 2.1.9 Bump version to 2.1.9 and update CHANGELOG Fix CHANGELOG nested ul indendation Fix multiple Code Climate issues on CHANGELOG Update CHANGELOG with bugfix notes Update CHANGELOG to use level 2 headings Bugfix: Prevent empty post title from rendering Bugfix: Fix typo in name of customizer filter version bump add unit tests for r_page_title_class add $display parameter to function update templates to use parameter Add filter to filter the page title class removing stray junk updating tests restoring code to old working version Add the global favicon back for non-BU domains version bump ... # Conflicts: # CHANGELOG.md
|
I've tested this and updated the branch with the latest develop, but I think something is no longer working. Here is my test site: http://id-ashley.cms-devl.bu.edu/kitchensink/ I added an empty BU Text widget to both the footbar and alternate footbar. I can see the incorrect widget count. On uploading this branch, the problem does not resolve. The homepage should show a count of 2, and any other page in the site should show a count of 9. I'm seeing 3 and 10 instead. There weren't any merge conflicts, so I'm a little stumped. This is probably easy to fix, but needs a set of developer eyes to keep moving. |
Fixes #45
Changes proposed in this pull request
responsive_is_widget_emptyto help check for empty widgets.Note: It would be preferable to update the plugins, however, the legacy code and impact of that change is large. This is a work around until BUText Widgets and BU Link Widgets are eventually deprecated in favor of Gutenberg.
Review checklist
[X] I've reviewed the contribution guidelines.
[X] I've updated
CHANGELOG.MDwith a brief explanation of the changes in this pull request in the unreleased section.[X] My code follows BU Coding Standards.