Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky symlink test on windows #3332

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Fix flaky symlink test on windows #3332

merged 1 commit into from
Sep 20, 2024

Conversation

emcfarlane
Copy link
Contributor

Fix flaky test failing to remove all as file is still open. Forces the close on the opened bucket object. Removes the t.Cleanup to allow testing to handle windows closes more gracefully. See https://github.com/golang/go/blob/c208b913954514ac7cab0fa701fba9c89af70392/src/testing/testing.go#L1271

--- FAIL: TestOS (0.00s)
    --- FAIL: TestOS/get_non_existent_file_symlink (1.27s)
        testing.go:1232: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestOSget_non_existent_file_symlink229375574\001\foo.txt: The process cannot access the file because it is being used by another proces

Copy link
Contributor

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedSep 20, 2024, 3:03 PM

Copy link
Contributor

@oliversun9 oliversun9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@emcfarlane emcfarlane merged commit 7a0cfd1 into main Sep 20, 2024
13 checks passed
@emcfarlane emcfarlane deleted the ed/fixWindowsFlake branch September 20, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants