Add missing API calls: manage hosted repositories, get integrations #48

cojoj · 2015-06-28T15:46:51Z

This is the first commit for the series of Let's support official API. This is a PR for #40 and it'll take a while to complete, especially that some majore changes are being made in #44.

Fell free to review, comment and suggest changes 👀

czechboy0 · 2015-06-28T16:12:52Z

XcodeServerSDK/XcodeServer.swift

+    - Optional retrieved integration.
+    - Optional operation error.
+    */
+    public func retrieveIntegration(integrationId: String, completion: (integration: Integration?, error: NSError?) -> ()) {


I'm not insistent on keeping it this way, but so far I've tried to name most of these API calls with words starting with get, post etc, to sort of mirror the HTTP verb convention. There are exceptions, like createBot (which could just be postBot), but I think, for the sake of users' autocompletion, that we should keep the first words as predictable as possible. Here I'd name it just getIntegrations. Whadaya think?

…into missing-api

czechboy0 · 2015-06-28T16:42:03Z

XcodeServerSDK/XcodeServer.swift

+    - parameter integrations:   Optional array of integrations.
+    - parameter error:          Optional error.
+    */
+    public func getIntegrations(completion: (integrations: [Integration]?, error: NSError?) -> ()) {


Btw, you can also use filters for integrations, see /Applications/Xcode-beta.app/Contents/Developer/usr/share/xcs/xcsd/routes/routes_integration.js. Not that you have to add it now, just FYI, probably something to add at some point in the future 😉

WOW, this is pretty cool! I'll add it for sure but I guess after #47 is complete so I don't get lost 😆

Haha yeah that makes sense. Let's split them first.

@czechboy0 while working on #47 I've noticed thath your method: getBotIntegrations() use filters. Do you have any clue where I can find available keys for this :filter? query? While Charlesing around I've noticed only one:

last=

So I went to integrationFilterClass.js but guess what - can't find anything... 😕 Give me some hints as I want to include those to header docs.

See integrationSearchClass.js starting from line 124. Filters like from, last, number etc.

Thank you‼️

I hate JS... 😕 Can't find anything in this mess! Hope Swift will replace it soon 😆

cojoj · 2015-06-28T22:55:30Z

@czechboy0 @esttorhe please review Repository struct. I wonder if it needs graceful way of breaking or something or can it stay the way it is now? The problem may occur when we pass other value than Int to httpAccessType or sshAccessType but I guess it'll never happen...

czechboy0 · 2015-06-28T23:32:05Z

XcodeServerSDK.xcodeproj/project.pbxproj

@@ -106,6 +106,9 @@
 		3AA922BA1B3F4666005A0F73 /* DVR.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 3AA922AC1B3F4630005A0F73 /* DVR.framework */; };
 		3ABE68661B3AC3C500FA0A61 /* DeviceSpecification.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3ABE68651B3AC3C500FA0A61 /* DeviceSpecification.swift */; };
 		3ABE68671B3AC3C500FA0A61 /* DeviceSpecification.swift in Sources */ = {isa = PBXBuildFile; fileRef = 3ABE68651B3AC3C500FA0A61 /* DeviceSpecification.swift */; };
+		7045917F1B4074CC00BA226C /* Repository.swift in Sources */ = {isa = PBXBuildFile; fileRef = 7045917E1B4074CC00BA226C /* Repository.swift */; };
+		704591861B40945700BA226C /* RepositoryTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 704591851B40945700BA226C /* RepositoryTests.swift */; };
+		704591871B40945E00BA226C /* RepositoryTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 704591851B40945700BA226C /* RepositoryTests.swift */; };


Do you know why it's duplicated?

That's a strange thing... Probably because of some kind of bug. I'll handle this 😉

Also, deleted duplication from .pbxproj file

czechboy0 · 2015-06-29T07:26:11Z

👍

cojoj · 2015-06-29T12:52:58Z

getRepositories() and createRepository() are available, working and with header documentation. Also 100% unit tests coverage for Repository class 😉

Please review this and add your 2 cents 💵 (@esttorhe I'm talking to you 😆)

cojoj · 2015-06-29T18:48:43Z

@czechboy0 I've changed the code to your suggestions, so feel free to review it one more time 👀

If you decide that what I've written in this PR is good enough to be merged please do so. I'd rather create new PR for other functionality not to confuse anyone.

czechboy0 · 2015-06-29T22:25:50Z

XcodeServerSDK/Server Entities/Repository.swift

+
+    public let name: String
+    public var httpAccess: HTTPAccessType = HTTPAccessType.None
+    public var sshAccess: SSHAccessType = SSHAccessType.SelectedReadWrite


Are you sure SSHAccessType.SelectedReadWrite should be the default? I think you need to pass an array of identifiers for the people that can actually read and write (those "selected"). Doesn't this default, together with empty arrays of readAccessExternalIds and writeAccessExternalIds basically mean that nobody can read and write?

If so, I'd suggest making LoggedInReadWrite the default, because that's the only option not requiring a list of identifiers to make sense. What do you think?

SSHAccessType.SelectedReadWrite is default and yes that means that nobody can access this repository if you pass empty arrays - strange but that's what I get in the response from XCS so I even double checked that 😜

Yeah, we can make LoggedInReadWrite as a default but I'll leave a comment if anyone will ever look for why we're not strict about this with XCS.

czechboy0 · 2015-06-29T22:31:24Z

Great stuff, I just added a couple minor comments. Once you fix those, I'll happily merge this! Just one more thing - feel free to also change the readme to account for the API calls you just added! We want to be proud of how much we support! 😊

czechboy0 · 2015-06-30T07:32:49Z

Amazing work. Thank you @cojoj! 👍

Add missing API calls: manage hosted repositories, get integrations

Add retrieve integration API call

8e8180b

cojoj mentioned this pull request Jun 28, 2015

Add missing functionalities to support API #40

Open

13 tasks

czechboy0 reviewed Jun 28, 2015
View reviewed changes

cojoj added 5 commits June 28, 2015 18:15

Add all integrations fetch API call

1cc90e9

Hot fix - name change

fd4b501

Hot fix - name change

2e39feb

Merge branch 'missing-api' of https://github.com/cojoj/XcodeServerSDK …

1b88861

…into missing-api

Merge remote-tracking branch 'origin/swift-2' into missing-api

0838576

czechboy0 reviewed Jun 28, 2015
View reviewed changes

cojoj added 2 commits June 28, 2015 19:30

Merge branch 'swift-2' into missing-api

c588a2f

Create Repository struct

2e9825b

Merge remote-tracking branch 'origin/swift-2' into missing-api

d022c9f

czechboy0 reviewed Jun 28, 2015
View reviewed changes

Add all repositories fetching method

0aa2e8e

Also, deleted duplication from .pbxproj file

cojoj added 2 commits June 29, 2015 13:45

Add convenience initializer and default values

5ee13ee

Add API call for creating repo and add test cases

ca9e64d

cojoj added 2 commits June 29, 2015 20:38

Upgrade to suggested changes

640bccd

Merge remote-tracking branch 'origin/swift-2' into missing-api

a333b7a

czechboy0 reviewed Jun 29, 2015
View reviewed changes

czechboy0 changed the title ~~[WIP] Add missing API calls~~ Add missing API calls Jun 29, 2015

czechboy0 changed the title ~~Add missing API calls~~ Add missing API calls: manage hosted repositories, get integrations Jun 29, 2015

Mateusz Zajac added 2 commits June 30, 2015 08:31

Batch of fixes

7eb6418

README support update

7fbd319

cojoj mentioned this pull request Jun 30, 2015

Increase test coverage #45

Closed

czechboy0 pushed a commit that referenced this pull request Jun 30, 2015

Merge pull request #48 from cojoj/missing-api

b876c53

Add missing API calls: manage hosted repositories, get integrations

czechboy0 merged commit b876c53 into buildasaurs:swift-2 Jun 30, 2015

cojoj deleted the missing-api branch June 30, 2015 07:46

cojoj mentioned this pull request Jun 30, 2015

Move API calls to separate files #47

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing API calls: manage hosted repositories, get integrations #48

Add missing API calls: manage hosted repositories, get integrations #48

cojoj commented Jun 28, 2015

czechboy0 Jun 28, 2015

cojoj Jun 28, 2015

czechboy0 Jun 28, 2015

cojoj Jun 28, 2015

czechboy0 Jun 28, 2015

cojoj Jul 1, 2015

czechboy0 Jul 1, 2015

cojoj Jul 1, 2015

cojoj commented Jun 28, 2015

czechboy0 Jun 28, 2015

cojoj Jun 29, 2015

czechboy0 commented Jun 29, 2015

cojoj commented Jun 29, 2015

cojoj commented Jun 29, 2015

czechboy0 Jun 29, 2015

cojoj Jun 30, 2015

czechboy0 commented Jun 29, 2015

czechboy0 commented Jun 30, 2015

Add missing API calls: manage hosted repositories, get integrations #48

Add missing API calls: manage hosted repositories, get integrations #48

Conversation

cojoj commented Jun 28, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cojoj commented Jun 28, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

czechboy0 commented Jun 29, 2015

cojoj commented Jun 29, 2015

cojoj commented Jun 29, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

czechboy0 commented Jun 29, 2015

czechboy0 commented Jun 30, 2015