Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing API calls: manage hosted repositories, get integrations #48

Merged
merged 16 commits into from
Jun 30, 2015
Merged

Add missing API calls: manage hosted repositories, get integrations #48

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
8e8180b
Add retrieve integration API call
cojoj Jun 28, 2015
1cc90e9
Add all integrations fetch API call
cojoj Jun 28, 2015
fd4b501
Hot fix - name change
cojoj Jun 28, 2015
2e39feb
Hot fix - name change
cojoj Jun 28, 2015
1b88861
Merge branch 'missing-api' of https://github.com/cojoj/XcodeServerSDK…
cojoj Jun 28, 2015
0838576
Merge remote-tracking branch 'origin/swift-2' into missing-api
cojoj Jun 28, 2015
c588a2f
Merge branch 'swift-2' into missing-api
cojoj Jun 28, 2015
2e9825b
Create Repository struct
cojoj Jun 28, 2015
d022c9f
Merge remote-tracking branch 'origin/swift-2' into missing-api
cojoj Jun 28, 2015
0aa2e8e
Add all repositories fetching method
Jun 29, 2015
5ee13ee
Add convenience initializer and default values
cojoj Jun 29, 2015
ca9e64d
Add API call for creating repo and add test cases
cojoj Jun 29, 2015
640bccd
Upgrade to suggested changes
cojoj Jun 29, 2015
a333b7a
Merge remote-tracking branch 'origin/swift-2' into missing-api
cojoj Jun 29, 2015
7eb6418
Batch of fixes
Jun 30, 2015
7fbd319
README support update
Jun 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions XcodeServerSDK/XcodeServer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,38 @@ public extension XcodeServer {
}
}

/**
XCS API call for retrievieng specified Integration.

- parameter integrationId: ID of integration which is about to be retrieved.
- parameter completion:
- Optional retrieved integration.
- Optional operation error.
*/
public func retrieveIntegration(integrationId: String, completion: (integration: Integration?, error: NSError?) -> ()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not insistent on keeping it this way, but so far I've tried to name most of these API calls with words starting with get, post etc, to sort of mirror the HTTP verb convention. There are exceptions, like createBot (which could just be postBot), but I think, for the sake of users' autocompletion, that we should keep the first words as predictable as possible. Here I'd name it just getIntegrations. Whadaya think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


let params = [
"integration": integrationId
]

self.sendRequestWithMethod(.GET, endpoint: .Integrations, params: params, query: nil, body: nil) {
(response, body, error) -> () in

guard error == nil else {
completion(integration: nil, error: error)
return
}

guard let integrationBody = body as? NSDictionary else {
completion(integration: nil, error: Error.withInfo("Wrong body \(body)"))
return
}

let integration = Integration(json: integrationBody)
completion(integration: integration, error: nil)
}
}

public func cancelIntegration(integrationId: String, completion: (success: Bool, error: NSError?) -> ()) {

let params = [
Expand Down