expands platform lifecycle tutorial #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hyounes4560
commented
Sep 23, 2024
hyounes4560
commented
- adds some content to the "Orchestrate a build with the CNB lifecycle" tutorial
- removes an extra character from https://buildpacks.io/docs/for-platform-operators/concepts/lifecycle/analyze/
Signed-off-by: Hanan Younes <[email protected]>
hyounes4560
changed the title
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
AidanDelaney
requested changes
Sep 23, 2024
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Hanan Younes <[email protected]>
Signed-off-by: Hanan Younes <[email protected]>
Signed-off-by: Hanan Younes <[email protected]>
hyounes4560
changed the title
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Hanan Younes <[email protected]>
AidanDelaney
requested changes
Oct 1, 2024
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Hanan Younes <[email protected]>
There was a problem hiding this comment.
Awesome work @hyounes4560! As Aidan mentioned this is looking quite good. I added many comments, but only a handful are truly substantive.
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
AidanDelaney
reviewed
Oct 4, 2024
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
AidanDelaney
reviewed
Oct 4, 2024
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
Make the recursive copy of samples work correctly in the expected tutorial directory structure. Co-authored-by: Natalie Arellano <[email protected]> Signed-off-by: Aidan Delaney <[email protected]>
AidanDelaney
reviewed
Oct 4, 2024
There was a problem hiding this comment.
I think we're almost good to go on this. Let's land all of @natalieparellano's suggestions. Then I'll run through it end-to-end again.
Signed-off-by: Hanan Younes <[email protected]>
… lifecycle-tutorial
|
@AidanDelaney I added most of @natalieparellano suggestions; left few that are a bit confusing. Please take a look. Thanks |
Signed-off-by: Hanan Younes <[email protected]>
Signed-off-by: Hanan Younes <[email protected]>
|
@AidanDelaney Please take a look; I added the latest comment |
Signed-off-by: Hanan Younes <[email protected]>
|
I think #773 will unblock this for landing. I'm happy to land it now...and create a ticket for @AidanDelaney to put in some tests. |
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Hanan Younes <[email protected]>
|
@AidanDelaney I just added the latest code suggestions; this should be ready to go. Thanks |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
* expands platform lifecycle tutorial Signed-off-by: Hanan Younes <[email protected]> * adds detect section & updates few links Signed-off-by: Hanan Younes <[email protected]> * Fix recursive copy of samples Make the recursive copy of samples work correctly in the expected tutorial directory structure. Co-authored-by: Natalie Arellano <[email protected]> Signed-off-by: Aidan Delaney <[email protected]> --------- Signed-off-by: Hanan Younes <[email protected]> Signed-off-by: Aidan Delaney <[email protected]> Co-authored-by: Aidan Delaney <[email protected]> Co-authored-by: Natalie Arellano <[email protected]> Co-authored-by: Aidan Delaney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.