Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expands platform lifecycle tutorial #769
expands platform lifecycle tutorial #769
Changes from 5 commits
d8f3a6e
6ccc5c9
751f86b
bb2241b
363b82e
d17e96a
14353cd
493f3bc
460c91b
84c25c7
21a4b89
f159da1
78ba3ce
4c7092c
3124781
28136b2
1cb041a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"root" typically means
/
, but in my case, running as a non-root user, I didn't have permission to make a directory there. I suggest we tell the user to make a "build root" directory and then update the commands to look something like:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used
/tmp/tutorial
as the root for my run-through.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is an simple solution to create a tmp dir for all this work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added code suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels a little bit heavy and kind of hides what is happening under the scenes. Can we just tell the end user what the directory tree should look like? (Or maybe we could do both)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't run the command so can't really comment on this.
@AidanDelaney could you take a look at this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The magic
for
loop creates a directory structure that looks like the following listing. In short, it takes our sample buildpacks from the source directory and puts them into the directory structure thatlifecycle
expects:@natalieparellano Do yuu think that explanation and the directory listing is sufficient? We can include the example along with the difficult to understand shell loop to generate the structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good - let's show the tree for just one buildpack to keep things short. Maybe before / after would explain it best
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about
Before running this command, the
samples/buildpacks
directory has the following structure:After, it has the following structure:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can add some minimal explanatory text here, similar to what we have for the analyzer - I'll leave a code suggestion hopefully "soon"Just links would be fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we link to https://buildpacks.io/docs/for-platform-operators/concepts/lifecycle/analyze/ for the explanation of what
analyzer
does?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That works for me - in general, we could add those links for every phase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I don't think we should create this file - it is the buildpack that does that during a normal build. We should probably just update our hello world buildpack to not be a complete no-op and actually contribute a process (cc @AidanDelaney)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack. Can we keep this right now and create an issue for me to update the samples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline, we'll create an issue and add a note here that we're faking the work of the buildpack