Allow applications to declare their own root routes #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if you tried to declare a public root route (without a unique `as:` reference) you'd get an `ArgumentError` saying: ``` Invalid route name, already in use: 'root' ``` Similary if you tried to declare an account scoped dashboard route (with an `as: 'dashboard'` reference) you'd get an `ArgumentError` saying: ``` Invalid route name, already in use: 'account_dashboard' ``` Both of these errors were happening when we tried to draw default routes after the application had already declared them. Now we resuce the `ArgumentError` and check the message to see if it's a complaint about a duplicate route. If so, we do nothing and let the app use the route defined in the primary `config/routes.rb` file. Fixes bullet-train-co/bullet_train#1656
jagthedrummer
added a commit
to bullet-train-co/bullet_train
that referenced
this pull request
Jan 29, 2025
jagthedrummer
added a commit
to bullet-train-co/bullet_train
that referenced
this pull request
Jan 29, 2025
* Document the fact that apps can declare their own root routes Joint PR: bullet-train-co/bullet_train-core#1013 * linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if you tried to declare a public root route (without a unique
as:reference) you'd get anArgumentErrorsaying:Similary if you tried to declare an account scoped dashboard route (with an
as: 'dashboard'reference) you'd get anArgumentErrorsaying:Both of these errors were happening when we tried to draw default routes after the application had already declared them.
Now we resuce the
ArgumentErrorand check the message to see if it's a complaint about a duplicate route. If so, we do nothing and let the app use the route defined in the primaryconfig/routes.rbfile.Fixes bullet-train-co/bullet_train#1656