Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow applications to declare their own root routes #1013

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Allow applications to declare their own root routes #1013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions bullet_train/config/routes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,16 @@
end

scope module: "public" do
root to: "home#index"
begin
root to: "home#index"
rescue ArgumentError => argument_error
if argument_error.message.match?("Invalid route name, already in use: 'root'")
# This means that a public root route has been declared by the application.
else
raise
end
end

get "invitation" => "home#invitation", :as => "invitation"

if Rails.env.development?
Expand All @@ -15,8 +24,16 @@

namespace :account do
shallow do
# TODO we need to either implement a dashboard or deprecate this.
root to: "dashboard#index", as: "dashboard"
begin
# TODO we need to either implement a dashboard or deprecate this.
root to: "dashboard#index", as: "dashboard"
rescue ArgumentError => argument_error
if argument_error.message.match?("Invalid route name, already in use: 'account_dashboard'")
# This means that an account scoped root/dashboard route has been declared by the application.
else
raise
end
end

resource :two_factor, only: [:create, :destroy] do
post :verify
Expand Down
Loading