Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocessing steps #305

Merged
merged 47 commits into from
Jun 14, 2024
Merged

Conversation

guynir42
Copy link
Member

@guynir42 guynir42 commented Jun 9, 2024

Refactor the way we request certain preprocessing steps to be done, e.g., applying flat or bias or fringe to certain images.

  • allows instruments to define a list of what steps they can do, and what steps they already done
  • user requests a set of steps to be done, either by pipeline or by the thing that provided the exposures.
  • allow skipping certain steps for specific filters.

@guynir42 guynir42 marked this pull request as ready for review June 9, 2024 19:13
@guynir42 guynir42 requested a review from rknop June 10, 2024 11:50
This was referenced Jun 13, 2024
Copy link
Contributor

@rknop rknop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

It occurs to me that the code assumes that DECam images always come in raw, and that's how we're usually doing it. But you can pull in reduced DECam images. When you do that, how do you specify that the steps_done field should be different from what's in the DECam class?

@guynir42 guynir42 merged commit 9d7d977 into c3-time-domain:main Jun 14, 2024
7 checks passed
@guynir42
Copy link
Member Author

I think the original idea would be to use a separate Instrument class for processed exposures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants