Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gap 2188 fix copy for document upload #83

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

paul-lawlor-tco
Copy link
Contributor

@paul-lawlor-tco paul-lawlor-tco commented Sep 26, 2023

Description

GAP-2188 (https://technologyprogramme.atlassian.net/browse/GAP-2188)

Summary of the changes and the related issue. List any dependencies that are required for this change:

Guidance was inconsistent between applicant and admin view for document upload selection. Content for grant admins was changed to be - "Allows files that are .DOC, .DOCX, .ODT, .PDF, .XLS, .XLSX or .ZIP"

Type of change

Please check the relevant options.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes:

  • Unit Test

  • Integration Test (if applicable)

  • End to End Test (if applicable)

Screenshots (if appropriate):

Document Upload selection
Screenshot 2023-09-26 at 16 31 14

Document Upload preview
Screenshot 2023-09-27 at 16 50 59

Please attach screenshots of the change if it is a UI change:
Screenshot attached which shows the new text added for document upload description when being viewed by admins.

Checklist:

  • If I have listed depedenencies above, I have ensured that they are present in the target branch.
  • I have performed a self-review of my code.
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the documentation where applicable.
  • I have ran cypress tests and they all pass locally.

@paul-lawlor-tco paul-lawlor-tco changed the title DRAFT: Gap 2188 fix copy for document upload Gap 2188 fix copy for document upload Sep 26, 2023
@paul-lawlor-tco paul-lawlor-tco changed the title Gap 2188 fix copy for document upload DRAFT: Gap 2188 fix copy for document upload Sep 27, 2023
@paul-lawlor-tco paul-lawlor-tco changed the title DRAFT: Gap 2188 fix copy for document upload Gap 2188 fix copy for document upload Sep 27, 2023
@paul-lawlor-tco paul-lawlor-tco merged commit b14a5b0 into develop Sep 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants