Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gap 2188 fix copy for document upload #83

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Gap 2188 fix copy for document upload #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6a96d1
Changed copy to be consistent with the description shown to applicant…
paul-lawlor-tco Sep 26, 2023
3ebdf76
Modified unit test 'Should have a document upload answer' to get the …
paul-lawlor-tco Sep 26, 2023
8e17b3c
Fixed failing unit test
paul-lawlor-tco Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ages/admin/src/pages/build-application/[applicationId]/[sectionId]/question-type.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ const QuestionType = ({
value: ResponseType.SingleFileUpload,
hint: (
<QuestionTypeHint
description="Allows all documents except .xls and .exe to be uploaded."
description="Allows files that are .DOC, .DOCX, .ODT, .PDF, .XLS, .XLSX or .ZIP"
questionType="document-upload"
imageFileName="document-upload"
imageAlt="A screenshot of a document upload component, with a button that allows the user to choose a file to upload"
Expand Down
2 changes: 1 addition & 1 deletion ...ages/admin/src/pages/build-application/[applicationId]/[sectionId]/question-type.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ describe('Question type', () => {
render(component);
screen.getByRole('radio', { name: 'Document upload' });
screen.getByText(
'Allows all documents except .xls and .exe to be uploaded.'
'Allows files that are .DOC, .DOCX, .ODT, .PDF, .XLS, .XLSX or .ZIP'
);
});

Expand Down
4 changes: 3 additions & 1 deletion packages/gap-web-ui/src/components/question-page/inputs/DocumentUpload.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,9 @@ describe('Document Upload component', () => {

it('Should render a label with the relevant accepted doc types', () => {
render(<DocumentUpload {...props()} />);
screen.getByText('Upload a file (all documents except .xls and .exe)');
screen.getByText(
'Upload a file (Allows files that are .DOC, .DOCX, .ODT, .PDF, .XLS, .XLSX or .ZIP)'
);
});

it('Should NOT render an error message when there are no field errors', () => {
Expand Down
3 changes: 2 additions & 1 deletion packages/gap-web-ui/src/components/question-page/inputs/DocumentUpload.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ const DocumentUpload = ({
)}

<label className="govuk-label govuk-!-margin-top-8" htmlFor={fieldName}>
Upload a file (all documents except .xls and .exe)
Upload a file (Allows files that are .DOC, .DOCX, .ODT, .PDF, .XLS,
.XLSX or .ZIP)
</label>

<ErrorMessage fieldErrors={fieldErrors} fieldName={fieldName} />
Expand Down
Loading