Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix client-side js crashing in webkit and firefox #99

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

jgunnCO
Copy link
Contributor

@jgunnCO jgunnCO commented Oct 12, 2023

Description

Fixes the client occasionally breaking on chrome when following a next link, and fixes Safari and Firefox reliably breaking as a result of fixing the first error.

Type of change

Please check the relevant options.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes:

  • Unit Test

  • Integration Test (if applicable)

  • End to End Test (if applicable)

Screenshots (if appropriate):

Please attach screenshots of the change if it is a UI change:

Checklist:

  • If I have listed depedenencies above, I have ensured that they are present in the target branch.
  • I have performed a self-review of my code.
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the documentation where applicable.
  • I have ran cypress tests and they all pass locally.

dylanwrightCO
dylanwrightCO previously approved these changes Oct 12, 2023
dylanwrightCO
dylanwrightCO previously approved these changes Oct 12, 2023
dominicwest
dominicwest previously approved these changes Oct 12, 2023
ConorFayleTCO
ConorFayleTCO previously approved these changes Oct 12, 2023
john-tco
john-tco previously approved these changes Oct 12, 2023
@jgunnCO jgunnCO merged commit 5bce0e8 into develop Oct 12, 2023
1 check passed
@jgunnCO jgunnCO deleted the feature/fix-webkit-firefox branch October 12, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants