Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ntrnl 451 add rate limit utils and mw to node web template #24

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Ntrnl 451 add rate limit utils and mw to node web template #24

merged 3 commits into from
Jun 24, 2024

Conversation

DanielMurray97
Copy link
Contributor

JIRA link

Resolves NTRNL-451

Description

  • Add rate limit middleware and integrate into app.
  • Solution pulled from the following PR completed by @harley-harris.

Work checklist

  • Tests added where applicable
  • No vulnerability added

@github-actions GitHub Actions
Copy link

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements 100% 166/166
🟢 Branches 94.12% 16/17
🟢 Functions 100% 17/17
🟢 Lines 100% 149/149
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟢
... / rateLimitHandler.middleware.ts
 100% 100% 100% 100%
🟢
... / rate-limit.ts
 100% 100% 100% 100%

Test suite run success

31 tests passing in 18 suites.

Report generated by 🧪jest coverage report action from 09c1fa8

@harley-harris harley-harris requested a review from a team June 24, 2024 13:57
harley-harris
harley-harris approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@harley-harris harley-harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled and tested locally, implementation works. Nice job ⚡

@DanielMurray97 DanielMurray97 merged commit 1a40376 into main Jun 24, 2024
7 checks passed
@DanielMurray97 DanielMurray97 deleted the NTRNL-451-add-rate-limit-utils-and-mw-to-node-web-template branch June 24, 2024 14:29
@Mouhajer-CO Mouhajer-CO mentioned this pull request Jul 1, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harley-harris harley-harris harley-harris approved these changes

Assignees

@DanielMurray97 DanielMurray97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielMurray97 @harley-harris