Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Manually download VisionOS SDK in CI #163

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

hmallen99
Copy link

Summary:

MacOS-14 runners no longer have the VisionOS SDK pre-installed, so we must download it prior to building for VisionOS: actions/runner-images#10559. We can use the same solution as React Native Test App: https://github.com/microsoft/react-native-test-app/pull/2258/files

Changelog:

  • Adds a step to the VisionOS test runner to download the VisionOS SDK before attempting to build with XCode

Pick one each for the category and type tags:

[VISIONOS] [FIXED]

Test Plan:

  • CI should pass after this change

@hmallen99 hmallen99 changed the title Manually download VisionOS SDK in CI fix: Manually download VisionOS SDK in CI Oct 17, 2024
Copy link
Member

@okwasniewski okwasniewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@okwasniewski okwasniewski merged commit 662ac82 into callstack:main Oct 17, 2024
28 checks passed
# https://github.com/actions/runner-images/issues/10559
sudo xcodebuild -runFirstLaunch
sudo xcrun simctl list
sudo xcodebuild -downloadPlatform visionOS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any chance this can be cached? downloading 6GB on every run is gonna add a few minutes to the CI time

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try adding the cache action, but we may run up against the storage limits for the action: https://github.com/actions/cache?tab=readme-ov-file#cache-limits. It looks like this repo is already over the limit, which could cause problems if more expensive artifacts get evicted from the cache.

An alternative would be to switch to macos-15/macos-latest for builds, which do have the visionos image, but I don't know if builds work on those runners.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, 10GB limit of cache is not gonna help really. We can try the macos-latest in a separate PR 👍🏼

@hmallen99 hmallen99 deleted the download-visionos-sdk branch October 17, 2024 15:00
okwasniewski pushed a commit that referenced this pull request Nov 27, 2024
okwasniewski pushed a commit that referenced this pull request Nov 27, 2024
okwasniewski pushed a commit that referenced this pull request Jan 7, 2025
okwasniewski pushed a commit that referenced this pull request Jan 7, 2025
okwasniewski pushed a commit that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants