Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Manually download VisionOS SDK in CI #163

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix: Manually download VisionOS SDK in CI #163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/actions/test-visionos-rntester/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,14 @@ runs:
ruby-version: ${{ inputs.ruby-version }}
- name: Setup xcode build cache
uses: ./.github/actions/setup-xcode-build-cache
- name: Download visionOS SDK
run: |
# https://github.com/actions/runner-images/issues/10559
sudo xcodebuild -runFirstLaunch
sudo xcrun simctl list
sudo xcodebuild -downloadPlatform visionOS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any chance this can be cached? downloading 6GB on every run is gonna add a few minutes to the CI time

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try adding the cache action, but we may run up against the storage limits for the action: https://github.com/actions/cache?tab=readme-ov-file#cache-limits. It looks like this repo is already over the limit, which could cause problems if more expensive artifacts get evicted from the cache.

An alternative would be to switch to macos-15/macos-latest for builds, which do have the visionos image, but I don't know if builds work on those runners.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, 10GB limit of cache is not gonna help really. We can try the macos-latest in a separate PR 👍🏼

sudo xcodebuild -runFirstLaunch
shell: bash
- name: Install CocoaPods dependencies
shell: bash
run: |
Expand Down
Loading