Improve job definition layout and contents in a handful of dirs in the base providers (BugFix) #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hook25
requested changes
Mar 21, 2024
Applied Max's suggestions (except one) Co-authored-by: Massimiliano <[email protected]>
Co-authored-by: Massimiliano <[email protected]>
fernando79513
requested changes
Jun 7, 2024
There was a problem hiding this comment.
I tried to take a look at most of them. There is still some inconsistency about how we use _summary and _purpose but I think this PR is an improvement overall.
I think mostly the summary should try to follow a common structure (short, all in infinitive, congruency on using test/check/assert) but I think that would be another IA pass with some clear instructions.
Comment on lines
+34
to
+35
| _purpose: Run gtkperf to make sure that GTK based test cases work | ||
| _summary: Ensures that GTK based test cases are operational by running gtkperf. |
There was a problem hiding this comment.
Summary should be shorter than the _purpose:
Suggested change
| _purpose: Run gtkperf to make sure that GTK based test cases work | |
| _summary: Ensures that GTK based test cases are operational by running gtkperf. | |
| _purpose: Ensures that GTK based test cases are operational by running gtkperf. | |
| _summary: Run gtkperf on all GTK based test cases |
Comment on lines
+54
to
+55
| _purpose: Run GLmark2-ES2 benchmark | ||
| _summary: Execute the GLmark2-ES2 benchmark on ARM devices. |
There was a problem hiding this comment.
Suggested change
| _purpose: Run GLmark2-ES2 benchmark | |
| _summary: Execute the GLmark2-ES2 benchmark on ARM devices. | |
| _purpose: Run GLmark2-ES2 benchmark (for ARM devices). | |
| _summary: Execute the GLmark2-ES2 benchmark. |
Comment on lines
+66
to
+67
| _purpose: Run GLmark2 benchmark | ||
| _summary: Execute GLmark2 benchmark and extract score. |
There was a problem hiding this comment.
Suggested change
| _purpose: Run GLmark2 benchmark | |
| _summary: Execute GLmark2 benchmark and extract score. | |
| _purpose: Run GLmark2 benchmark (for x86/amd64 devices) | |
| _summary: Execute GLmark2 benchmark. |
Comment on lines
+61
to
+76
| _purpose: | ||
| This test will check that the Bluetooth connection works correctly | ||
| _steps: | ||
| 1. Enable Bluetooth on any mobile device (PDA, smartphone, etc.) | ||
| 2. Click on the Bluetooth icon in the menu bar | ||
| 3. Select 'Setup new device' | ||
| 4. Look for the device in the list and select it | ||
| 5. On the device, enter the PIN code automatically chosen by the wizard | ||
| 6. The device should pair with the computer | ||
| 7. Right-click on the Bluetooth icon and select browse files | ||
| 8. Authorize the computer to browse the files on the device if needed | ||
| 9. You should be able to browse the files | ||
| _verification: | ||
| Did all the steps work? | ||
| _summary: | ||
| Verify the functionality of browsing files over a Bluetooth connection. |
There was a problem hiding this comment.
Suggested change
| _purpose: | |
| This test will check that the Bluetooth connection works correctly | |
| _steps: | |
| 1. Enable Bluetooth on any mobile device (PDA, smartphone, etc.) | |
| 2. Click on the Bluetooth icon in the menu bar | |
| 3. Select 'Setup new device' | |
| 4. Look for the device in the list and select it | |
| 5. On the device, enter the PIN code automatically chosen by the wizard | |
| 6. The device should pair with the computer | |
| 7. Right-click on the Bluetooth icon and select browse files | |
| 8. Authorize the computer to browse the files on the device if needed | |
| 9. You should be able to browse the files | |
| _verification: | |
| Did all the steps work? | |
| _summary: | |
| Verify the functionality of browsing files over a Bluetooth connection. | |
| _purpose: | |
| This test will verify the functionality of browsing files over a Bluetooth connection. | |
| _steps: | |
| 1. Enable Bluetooth on any mobile device (PDA, smartphone, etc.) | |
| 2. Click on the Bluetooth icon in the menu bar | |
| 3. Select 'Setup new device' | |
| 4. Look for the device in the list and select it | |
| 5. On the device, enter the PIN code automatically chosen by the wizard | |
| 6. The device should pair with the computer | |
| 7. Right-click on the Bluetooth icon and select browse files | |
| 8. Authorize the computer to browse the files on the device if needed | |
| 9. You should be able to browse the files | |
| _verification: | |
| Did all the steps work? | |
| _summary: | |
| Test browsing files over a Bluetooth connection. |
Comment on lines
+84
to
+96
| _purpose: | ||
| This test will check that you can transfer information through a bluetooth connection | ||
| _steps: | ||
| 1. Enable bluetooth on a target device (e.g., another laptop) and DUT (device under test) | ||
| 2. Launch bluetooth settings from menu bar | ||
| 3. Select target device from Device options for connection establishing | ||
| 4. Confirm PIN code on both DUT and target device | ||
| 5. Target device is connected | ||
| 7. Click target device in device list | ||
| 8. Click 'Send Files...' and choose a file to send in DUT | ||
| _verification: | ||
| Were files sent to the target device's ~/Downloads folder correctly? | ||
| _summary: Verify the capability to transfer files through a Bluetooth connection. |
There was a problem hiding this comment.
Suggested change
| _purpose: | |
| This test will check that you can transfer information through a bluetooth connection | |
| _steps: | |
| 1. Enable bluetooth on a target device (e.g., another laptop) and DUT (device under test) | |
| 2. Launch bluetooth settings from menu bar | |
| 3. Select target device from Device options for connection establishing | |
| 4. Confirm PIN code on both DUT and target device | |
| 5. Target device is connected | |
| 7. Click target device in device list | |
| 8. Click 'Send Files...' and choose a file to send in DUT | |
| _verification: | |
| Were files sent to the target device's ~/Downloads folder correctly? | |
| _summary: Verify the capability to transfer files through a Bluetooth connection. | |
| _purpose: | |
| This test will verify the capability to transfer files through a Bluetooth connection. | |
| _steps: | |
| 1. Enable bluetooth on a target device (e.g., another laptop) and DUT (device under test) | |
| 2. Launch bluetooth settings from menu bar | |
| 3. Select target device from Device options for connection establishing | |
| 4. Confirm PIN code on both DUT and target device | |
| 5. Target device is connected | |
| 7. Click target device in device list | |
| 8. Click 'Send Files...' and choose a file to send in DUT | |
| _verification: | |
| Were files sent to the target device's ~/Downloads folder correctly? | |
| _summary: Test file transfer over a Bluetooth connection. |
| @@ -1442,16 +1451,16 @@ _verification: | |||
| The verification of this test is automated. Do not change the | |||
| automatically selected result. | |||
|
|
|||
|
|
|||
| @@ -2214,16 +2219,16 @@ _verification: | |||
| The verification of this test is automated. Do not change the | |||
| automatically selected result. | |||
|
|
|||
|
|
|||
| _verification: | ||
| The verification of this test is automated. Do not change the | ||
| automatically selected result. | ||
| _summary: Check the system's detection of a USB 3.0 storage device removal through a USB Type-C to Type-A adapter. |
There was a problem hiding this comment.
Suggested change
| _summary: Check the system's detection of a USB 3.0 storage device removal through a USB Type-C to Type-A adapter. | |
| _summary: Verify the detection of a USB 3.0 storage device removal through a USB Type-C to Type-A adapter. |
| @@ -844,6 +841,7 @@ _steps: | |||
| _verification: | |||
| The verification of this test is automated. Do not change the | |||
| automatically selected result. | |||
| _summary: Verify system detection of a USB 3 storage device insertion on a dock's USB Type-C port. | |||
There was a problem hiding this comment.
Suggested change
| _summary: Verify system detection of a USB 3 storage device insertion on a dock's USB Type-C port. | |
| _summary: Verify the detection of a USB 3 storage device insertion on a dock's USB Type-C port. |
| @@ -821,6 +817,7 @@ _steps: | |||
| _verification: | |||
| The verification of this test is automated. Do not change the | |||
| automatically selected result. | |||
| _summary: Verify system detection of a USB 3 storage device inserted into a USB Type-C connector using a Type-C to Type-A adapter. | |||
There was a problem hiding this comment.
Suggested change
| _summary: Verify system detection of a USB 3 storage device inserted into a USB Type-C connector using a Type-C to Type-A adapter. | |
| _summary: Verify the detection of a USB 3 storage device inserted into a USB Type-C port using a Type-C to Type-A adapter. |
|
Rebased and merged separately. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another portion of changes done by the pxu-fixer.
I added the hunks by hand to do a front-line review.
The changes proposed here are/should be only cosmetic.