-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve job definition layout and contents in a handful of dirs in the base providers (BugFix) #1088
Closed
Closed
Improve job definition layout and contents in a handful of dirs in the base providers (BugFix) #1088
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
23d1e38
move to _purpose from _description in 6LoWPAN
kissiel f2ee442
correct the dock test definitions
kissiel 906f283
fix the acpi tests
kissiel 539c16c
fix the benchmarks job definitions
kissiel c93c913
fix the Bluetooth job definitions
kissiel 27ac71f
fix the camera job definitions
kissiel a44d227
fix the codecs job definitions
kissiel 2429275
fix the cpu job definitions
kissiel a6966c2
fix the cpu disk definitions
kissiel f461ed8
remove the problematic newline
kissiel db1f61c
Apply suggestions from code review
kissiel 9dd66ca
Apply suggestions from code review
fernando79513 737f21e
Applied suggestion in bluetooth
fernando79513 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -9,7 +9,7 @@ estimated_duration: 15.0 | |||||||||
user: root | ||||||||||
command: hdparm -t /dev/{name} | ||||||||||
_summary: Raw read timing benchmark of {name} using hdparm | ||||||||||
_description: This test runs hdparm timing of device reads as a benchmark for {name} | ||||||||||
_purpose: This test runs hdparm timing of device reads as a benchmark for {name} | ||||||||||
|
||||||||||
unit: template | ||||||||||
template-resource: device | ||||||||||
|
@@ -22,7 +22,7 @@ estimated_duration: 10.0 | |||||||||
user: root | ||||||||||
command: hdparm -T /dev/{name} | ||||||||||
_summary: Cached read timing benchmark of {name} using hdparm | ||||||||||
_description: This test runs hdparm timing of cache reads as a benchmark for {name} | ||||||||||
_purpose: This test runs hdparm timing of cache reads as a benchmark for {name} | ||||||||||
|
||||||||||
plugin: shell | ||||||||||
category_id: com.canonical.plainbox::benchmarks | ||||||||||
|
@@ -31,16 +31,17 @@ depends: graphics/xorg-version | |||||||||
requires: package.name == 'gtkperf' | ||||||||||
command: python3 -c 'import re,sys,subprocess; (s, o) = subprocess.getstatusoutput("gtkperf -a"); [sys.exit(1) for i in [s] if s]; m = re.search("Total time:\s+(.*)\n", o); [print(i.group(1)+" Seconds") for i in [m] if m]' | ||||||||||
estimated_duration: 30.000 | ||||||||||
_description: | ||||||||||
Run gtkperf to make sure that GTK based test cases work | ||||||||||
_purpose: Run gtkperf to make sure that GTK based test cases work | ||||||||||
_summary: Ensures that GTK based test cases are operational by running gtkperf. | ||||||||||
|
||||||||||
plugin: shell | ||||||||||
category_id: com.canonical.plainbox::benchmarks | ||||||||||
id: benchmarks/graphics/render-bench | ||||||||||
requires: package.name == 'render-bench' | ||||||||||
command: /usr/bin/time -f "%e Seconds" render_bench > /dev/null 2>&1 | ||||||||||
estimated_duration: 52.000 | ||||||||||
_description: Run Render-Bench XRender/Imlib2 benchmark | ||||||||||
_summary: Run Render-Bench XRender/Imlib2 benchmark | ||||||||||
_purpose: Execute the Render-Bench XRender/Imlib2 benchmark to assess graphics performance. | ||||||||||
|
||||||||||
plugin: shell | ||||||||||
category_id: com.canonical.plainbox::benchmarks | ||||||||||
|
@@ -50,7 +51,8 @@ requires: | |||||||||
'arm' in cpuinfo.type | ||||||||||
command: | ||||||||||
glmark2-es2 2>&1 | sed -e :a -e '$!N;s/\n/ /;ta' | sed -E 's/.*(Score:\s+[0-9]+).*/\1/' | ||||||||||
_description: Run GLmark2-ES2 benchmark | ||||||||||
_purpose: Run GLmark2-ES2 benchmark | ||||||||||
_summary: Execute the GLmark2-ES2 benchmark on ARM devices. | ||||||||||
Comment on lines
+54
to
+55
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
|
||||||||||
plugin: shell | ||||||||||
category_id: com.canonical.plainbox::benchmarks | ||||||||||
|
@@ -61,30 +63,34 @@ requires: | |||||||||
command: | ||||||||||
glmark2 2>&1 | sed -e :a -e '$!N;s/\n/ /;ta' | sed -E 's/.*(Score:\s+[0-9]+).*/\1/' | ||||||||||
estimated_duration: 306.000 | ||||||||||
_description: Run GLmark2 benchmark | ||||||||||
_purpose: Run GLmark2 benchmark | ||||||||||
_summary: Execute GLmark2 benchmark and extract score. | ||||||||||
Comment on lines
+66
to
+67
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
|
||||||||||
plugin: shell | ||||||||||
category_id: com.canonical.plainbox::benchmarks | ||||||||||
id: benchmarks/network/wifi_time_to_reconnect | ||||||||||
requires: device.category == 'WIRELESS' | ||||||||||
command: wifi_time2reconnect.py | ||||||||||
_description: Check the time needed to reconnect to a WIFI access point | ||||||||||
_purpose: Check the time needed to reconnect to a WIFI access point | ||||||||||
_summary: Measure WIFI reconnection time. | ||||||||||
|
||||||||||
plugin: shell | ||||||||||
category_id: com.canonical.plainbox::benchmarks | ||||||||||
id: benchmarks/system/cpu_on_idle | ||||||||||
estimated_duration: 10.0 | ||||||||||
requires: package.name == 'sysstat' | ||||||||||
command: iostat -x -m 1 10 | python3 -c 'import sys, re; lines="".join(sys.stdin.readlines()); l=[float(n) for n in (re.findall("idle\n.*?(\S+)\n", lines))]; print(sum(l)/len(l),"%")' | ||||||||||
_description: CPU utilization on an idle system. | ||||||||||
_purpose: CPU utilization on an idle system. | ||||||||||
_summary: Measure CPU utilization on an idle system. | ||||||||||
|
||||||||||
plugin: shell | ||||||||||
category_id: com.canonical.plainbox::benchmarks | ||||||||||
id: benchmarks/system/disk_on_idle | ||||||||||
estimated_duration: 10.0 | ||||||||||
requires: package.name == 'sysstat' | ||||||||||
command: iostat -x -m 1 10 | python3 -c 'import sys, re; lines="".join(sys.stdin.readlines()); l=[float(n) for n in (re.findall("util\n.*?(\S+)\n", lines))]; print(sum(l)/len(l),"%")' | ||||||||||
_description: Disk utilization on an idle system. | ||||||||||
_purpose: Disk utilization on an idle system. | ||||||||||
_summary: Measure disk utilization on an idle system. | ||||||||||
|
||||||||||
plugin: shell | ||||||||||
category_id: com.canonical.plainbox::benchmarks | ||||||||||
|
@@ -94,9 +100,8 @@ requires: | |||||||||
cpuinfo.platform == 'x86_64' | ||||||||||
command: gputest_benchmark.py fur --width 1920 --height 1080 -f | ||||||||||
estimated_duration: 75.000 | ||||||||||
_description: | ||||||||||
Run a stress test based on FurMark (OpenGL 2.1 or 3.2) | ||||||||||
Fullscreen 1920x1080 no antialiasing | ||||||||||
_purpose: Run a stress test based on FurMark (OpenGL 2.1 or 3.2)in Fullscreen 1920x1080 no antialiasing | ||||||||||
_summary: Conduct a FurMark stress test in fullscreen 1920x1080 without antialiasing. | ||||||||||
|
||||||||||
plugin: shell | ||||||||||
category_id: com.canonical.plainbox::benchmarks | ||||||||||
|
@@ -106,9 +111,8 @@ requires: | |||||||||
cpuinfo.platform == 'x86_64' | ||||||||||
command: gputest_benchmark.py fur | ||||||||||
estimated_duration: 75.000 | ||||||||||
_description: | ||||||||||
Run a stress test based on FurMark (OpenGL 2.1 or 3.2) | ||||||||||
Windowed 1024x640 no antialiasing | ||||||||||
_purpose: Run a stress test based on FurMark (OpenGL 2.1 or 3.2) Windowed 1024x640 no antialiasing | ||||||||||
_summary: Conduct a FurMark-based OpenGL stress test at 1024x640 without antialiasing. | ||||||||||
|
||||||||||
plugin: shell | ||||||||||
category_id: com.canonical.plainbox::benchmarks | ||||||||||
|
@@ -118,9 +122,8 @@ requires: | |||||||||
cpuinfo.platform == 'x86_64' | ||||||||||
command: gputest_benchmark.py gi --width 1920 --height 1080 -f | ||||||||||
estimated_duration: 75.00 | ||||||||||
_description: | ||||||||||
Run GiMark, a geometry instancing test (OpenGL 3.3) | ||||||||||
Fullscreen 1920x1080 no antialiasing | ||||||||||
_purpose: Run GiMark, a geometry instancing test (OpenGL 3.3) Fullscreen 1920x1080 no antialiasing | ||||||||||
_summary: Run GiMark OpenGL 3.3 benchmark at 1920x1080 fullscreen without antialiasing. | ||||||||||
|
||||||||||
plugin: shell | ||||||||||
category_id: com.canonical.plainbox::benchmarks | ||||||||||
|
@@ -130,9 +133,9 @@ requires: | |||||||||
cpuinfo.platform == 'x86_64' | ||||||||||
command: gputest_benchmark.py gi | ||||||||||
estimated_duration: 75.500 | ||||||||||
_description: | ||||||||||
Run GiMark, a geometry instancing test (OpenGL 3.3) | ||||||||||
Windowed 1024x640 no antialiasing | ||||||||||
_purpose: | ||||||||||
Run GiMark, a geometry instancing test (OpenGL 3.3) in a windowed 1024x640 resolution without antialiasing. | ||||||||||
_summary: Run GiMark OpenGL 3.3 geometry test at 1024x640 windowed without antialiasing. | ||||||||||
|
||||||||||
plugin: shell | ||||||||||
category_id: com.canonical.plainbox::benchmarks | ||||||||||
|
@@ -142,9 +145,8 @@ requires: | |||||||||
cpuinfo.platform == 'x86_64' | ||||||||||
command: gputest_benchmark.py tess --width 1920 --height 1080 -f | ||||||||||
estimated_duration: 75.000 | ||||||||||
_description: | ||||||||||
Run a tessellation test based on TessMark (OpenGL 4.0) | ||||||||||
Fullscreen 1920x1080 no antialiasing | ||||||||||
_purpose: Run a tessellation test based on TessMark (OpenGL 4.0), fullscreen 1920x1080 with no antialiasing. | ||||||||||
_summary: Run TessMark tessellation test at 1920x1080 fullscreen without antialiasing. | ||||||||||
|
||||||||||
plugin: shell | ||||||||||
category_id: com.canonical.plainbox::benchmarks | ||||||||||
|
@@ -153,6 +155,5 @@ requires: | |||||||||
package.name == 'gputest' | ||||||||||
cpuinfo.platform == 'x86_64' | ||||||||||
command: gputest_benchmark.py tess | ||||||||||
_description: | ||||||||||
Run a tessellation test based on TessMark (OpenGL 4.0) | ||||||||||
Windowed 1024x640 no antialiasing | ||||||||||
_purpose: Run a tessellation test based on TessMark (OpenGL 4.0) Windowed 1024x640 no antialiasing | ||||||||||
_summary: Run TessMark tessellation test at 1024x640 windowed without antialiasing. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary should be shorter than the _purpose: