Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ISHTP and ECLITE test cases and plans from iiotg provider and checkbox-iiotg-provder (New) #895

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

LiaoU3
Copy link
Contributor

@LiaoU3 LiaoU3 commented Dec 14, 2023

Description

I move the ISHTP and ECLITE related test jobs and plans from checkbox-provider-intliotg and iiotg provider to base provider.

Resolved issues

N/A

Documentation

N/A

Tests

I ran the testplan ishtp-full or you could say Intel Integrated Sensor Hub Transport Protocol (ISHTP) tests (Full) on EHL (202306-31657) and TGL (202306-31658).

@LiaoU3 LiaoU3 marked this pull request as draft December 14, 2023 09:58
@LiaoU3 LiaoU3 marked this pull request as ready for review December 15, 2023 02:41
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (582d483) 36.54% compared to head (22051d0) 36.74%.
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #895      +/-   ##
==========================================
+ Coverage   36.54%   36.74%   +0.20%     
==========================================
  Files         310      310              
  Lines       34634    34632       -2     
  Branches     5964     5964              
==========================================
+ Hits        12656    12725      +69     
+ Misses      21408    21337      -71     
  Partials      570      570              
Flag Coverage Δ
provider-base 5.99% <ø> (+0.49%) ⬆️
provider-iiotg 100.00% <ø> (ø)
providers ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pieqq
Copy link
Collaborator

pieqq commented Dec 19, 2023

/canonical/self-hosted-runners/run-workflows d151cec

@LiaoU3 LiaoU3 changed the title Add ISHTP and ECLITE test cases and plans in iiotg provider (New) Move ISHTP and ECLITE test cases and plans from iiotg provider and checkbox-iiotg-provder (New) Dec 20, 2023
pieqq
pieqq previously approved these changes Jan 9, 2024
Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I left a few comments for you to review, but overall this PR looks fine.

providers/base/units/ishtp/jobs.pxu Show resolved Hide resolved
providers/base/units/ishtp/jobs.pxu Show resolved Hide resolved
providers/base/units/ishtp/jobs.pxu Outdated Show resolved Hide resolved
Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks a lot!

@pieqq pieqq merged commit 49d7a4e into canonical:main Jan 9, 2024
16 checks passed
LiaoU3 added a commit to LiaoU3/checkbox that referenced this pull request Mar 20, 2024
canonical#895)

* Move ISHTP and ECLITE test cases from checkbox-iiotg-provider and iiotg provider

* Put the command field for eclite/temperature-reading-from-thermal-acpitz into shell script

* Add estimated_duration for the job eclite/temperature-reading-from-thermal-acpitz
binli pushed a commit to binli/checkbox that referenced this pull request Mar 22, 2024
canonical#895)

* Move ISHTP and ECLITE test cases from checkbox-iiotg-provider and iiotg provider

* Put the command field for eclite/temperature-reading-from-thermal-acpitz into shell script

* Add estimated_duration for the job eclite/temperature-reading-from-thermal-acpitz
@LiaoU3 LiaoU3 deleted the migrate_iotg_ishtp branch April 2, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants