Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROCKS 1452 - Refactor Build Rock workflow to be externally reusable #233

Open
wants to merge 65 commits into
base: main
Choose a base branch
from
Open

ROCKS 1452 - Refactor Build Rock workflow to be externally reusable #233

wants to merge 65 commits into from

Conversation

clay-lake
Copy link
Contributor

@clay-lake clay-lake commented Aug 23, 2024 •
edited
Loading

Note: This PR depends on #224
This pull request refactors the build workflow to enable re-usability by external repositories. There is an example application of this in the rocks-toolbox. A example job run can be found here: https://github.com/canonical/rocks-toolbox/actions/runs/10524164671

@clay-lake clay-lake changed the title DRAFT ROCKS 1452 - Refactor Build Rock workflow to be externally reusable DRAFT - ROCKS 1452 - Refactor Build Rock workflow to be externally reusable Aug 23, 2024
@clay-lake clay-lake changed the title DRAFT - ROCKS 1452 - Refactor Build Rock workflow to be externally reusable ROCKS 1452 - Refactor Build Rock workflow to be externally reusable Aug 26, 2024
@clay-lake clay-lake marked this pull request as ready for review September 3, 2024 08:26
@clay-lake
Copy link
Contributor Author

Since it is not part of the checks, here is an example Test OCI Factory run from e6e3c29
https://github.com/canonical/oci-factory/actions/runs/10678234515

zhijie-yang
zhijie-yang requested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@zhijie-yang zhijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! Leaving several nitpicks:

.github/workflows/Build-Rock.yaml Outdated Show resolved Hide resolved
src/build_rock/configure/generate_build_matrix.py Outdated Show resolved Hide resolved
.github/workflows/Build-Rock.yaml Outdated Show resolved Hide resolved
.github/workflows/Build-Rock.yaml Show resolved Hide resolved
.github/workflows/Image.yaml Show resolved Hide resolved
src/shared/github_output.py Show resolved Hide resolved
tests/fixtures/__ini__.py Outdated Show resolved Hide resolved
tests/integration/test_convert_junit_xml_to_markdown.py Outdated Show resolved Hide resolved
tests/unit/test_generate_build_matrix.py Outdated Show resolved Hide resolved
tests/unit/test_github_output.py Outdated Show resolved Hide resolved
linostar
linostar requested changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. I left few minor remarks and nitpicks.

.github/workflows/Build-Rock.yaml Outdated Show resolved Hide resolved
.github/workflows/Build-Rock.yaml Outdated Show resolved Hide resolved
.github/workflows/Build-Rock.yaml Show resolved Hide resolved
.github/workflows/Build-Rock.yaml Outdated Show resolved Hide resolved
.github/workflows/Build-Rock.yaml Show resolved Hide resolved
src/build_rock/configure/generate_build_matrix.py Show resolved Hide resolved
src/build_rock/configure/generate_build_matrix.py Show resolved Hide resolved
@clay-lake clay-lake force-pushed the ROCKS-1452/oci-factory-refactor-build-rock-to-be-externally-reusable branch from 370b1aa to 134291d Compare September 6, 2024 11:38
clay-lake and others added 8 commits September 6, 2024 11:48
@clay-lake
Merge branch 'main' of https://github.com/canonical/oci-factory into …
f5b8d15 
…ROCKS-1452/oci-factory-refactor-build-rock-to-be-externally-reusable
@clay-lake
Merge branch 'ROCKS-1452/oci-factory-refactor-build-rock-to-be-extern…
41f7d75 
…ally-reusable' of https://github.com/canonical/oci-factory into ROCKS-1452/oci-factory-refactor-build-rock-to-be-externally-reusable
@clay-lake clay-lake requested a review from a team as a code owner September 16, 2024 11:37
zhijie-yang
zhijie-yang approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@zhijie-yang zhijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

cjdcordeiro
cjdcordeiro requested changes Sep 16, 2024
View reviewed changes
.github/workflows/Build-Rock.yaml Outdated Show resolved Hide resolved
clay-lake and others added 30 commits October 9, 2024 07:48
@clay-lake
fix: correct folder name validation
d73c323
@clay-lake
test build: check folder_name
296eb23
@clay-lake
fix: disable image folder validation
3670096
@clay-lake
test build
616f4db
@clay-lake
feat: add access validation job
3d342f3
@clay-lake
trigger test build
d44fa58
@clay-lake
fix(.github/workflows/Build-Rock.yaml): invalid yaml syntax
f4319ef
@clay-lake
fix: path validation and step namea
168bc23
@clay-lake
refactor: move path validation outside of build rock repo
445c324
@clay-lake
feat: added job to image workflow for matrix validation
3b0933b
@clay-lake
fix(Image.yaml): bad job name
426cdff
@clay-lake
refactor(Image.yaml): adjust whitespace and comments
f988941
ci: automatically update oci/mock-rock/_releases.json, from https://g…
3511bce 
…ithub.com/canonical/oci-factory/actions/runs/11252315563
@clay-lake
test: github property exposing wf call params
51968d1
@clay-lake
Merge branch 'ROCKS-1452/oci-factory-refactor-build-rock-to-be-extern…
899df8c 
…ally-reusable' of https://github.com/canonical/oci-factory into ROCKS-1452/oci-factory-refactor-build-rock-to-be-externally-reusable
ci: automatically update oci/mock-rock/_releases.json, from https://g…
9e21470 
…ithub.com/canonical/oci-factory/actions/runs/11253931903
@clay-lake
feat: forward workflow ref to self checkout
9430e88
@clay-lake
Merge branch 'ROCKS-1452/oci-factory-refactor-build-rock-to-be-extern…
d62e023 
…ally-reusable' of https://github.com/canonical/oci-factory into ROCKS-1452/oci-factory-refactor-build-rock-to-be-externally-reusable
@clay-lake
test build
786af95
@clay-lake
test: canonical/get-workflow-version-action@v1
4201240
@clay-lake
fix: missing toJSON call
5bd360c
@clay-lake
test: checkout self according to sha
d1e0edb
@clay-lake
fix: bash syntax error
df5df0d
@clay-lake
fix: bash syntax error
271c535
@clay-lake
fix: syntax errors in workflow
dc7b533
@clay-lake
fix: correct step name
b6d8a23
@clay-lake
test: adaptor git checkout action
d7e543b
@clay-lake
fix: missing file extension
fb7ee58
@clay-lake
fix: bad action path
0e848d3
ci: automatically update oci/mock-rock/_releases.json, from https://g…
67947b0 
…ithub.com/canonical/oci-factory/actions/runs/11258034237
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjdcordeiro cjdcordeiro cjdcordeiro requested changes

@zhijie-yang zhijie-yang zhijie-yang approved these changes

@linostar linostar Awaiting requested review from linostar

Assignees
No one assigned
Labels
priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clay-lake @linostar @cjdcordeiro @zhijie-yang