Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROCKS 1452 - Refactor Build Rock workflow to be externally reusable #233
base: main
Are you sure you want to change the base?
ROCKS 1452 - Refactor Build Rock workflow to be externally reusable #233
Changes from 11 commits
134291d
962aa3c
3007b0b
a70a819
11e9887
f3514ef
3902e82
7f362cb
94a5722
f5b8d15
41f7d75
a175429
448b8a2
3c5d295
c3e30c9
dacd870
55ed796
403d559
1bb9f6d
4cbf7c2
151ddcd
001ddde
922dd23
22a6236
b2e471d
73ef99a
b2ecdcf
34d14cd
a22eb9d
ac8dee4
c0a869c
34a2bbe
bdabf43
cc48df3
842aa07
d73c323
296eb23
3670096
616f4db
3d342f3
d44fa58
f4319ef
168bc23
445c324
3b0933b
426cdff
f988941
3511bce
51968d1
899df8c
9e21470
9430e88
d62e023
786af95
4201240
5bd360c
d1e0edb
df5df0d
271c535
dc7b533
b6d8a23
d7e543b
fb7ee58
0e848d3
67947b0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you removing this? Without it, non-github repos won't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(mentioned above in https://github.com/canonical/oci-factory/pull/233/files#diff-dd4702d1da9984f398938d6d41f0c95aef455bcedbbe87ed3f336b9e0259ab9eL14)
this shouldn't be removed. is a needed assertion for in-repo builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if using LPCI, I think you're not setting the
runner
at https://github.com/canonical/oci-factory/pull/233/files#diff-d14de60b7f1da617d4f2bec5847471874842e992154e38edcf760909e46d8dcdR58. Even if GH somehow defaults to something, it would be better to set the default value explicitly, to be predictable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're losing useful logging information here. the name of the rock helps a lot with the GUI navigation when the matrix is big
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as above - this is needed for non-GH repos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above, we could use the rock's name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comments as above wrt non-GH repos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: not sure if there are others like this, but better run a yaml formatter on all these files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem. Do we have a preferred autoformatter? I can add it to the docs.