Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging_revamp replace module loggers SC-1539 #2558

Merged
merged 6 commits into from
Jul 27, 2023
Merged

logging_revamp replace module loggers SC-1539 #2558

merged 6 commits into from
Jul 27, 2023

Conversation

CalvoM
Copy link
Contributor

@CalvoM CalvoM commented Apr 19, 2023

Proposed Commit Message

Logging revamp replace module loggers

NO-LP NO-GH

Add logger in modules instead of the root logger.

Test Steps

Checklist

  • I have updated or added any unit tests accordingly
  • I have updated or added any integration tests accordingly
  • I have updated or added any documentation accordingly

Does this PR require extra reviews?

  • Yes
  • No

@CalvoM CalvoM force-pushed the logging_revamp-replace_module_loggers branch 5 times, most recently from 2b7a8ef to d0d55a8 Compare April 20, 2023 11:07
orndorffgrant
orndorffgrant reviewed Apr 27, 2023
View reviewed changes
lib/apt_news.py Outdated Show resolved Hide resolved
lib/apt_news.py Outdated Show resolved Hide resolved
lib/apt_news.py Outdated Show resolved Hide resolved
uaclient/api/api.py Outdated Show resolved Hide resolved
uaclient/util.py Outdated Show resolved Hide resolved
@CalvoM CalvoM changed the title Logging revamp replace module loggers SC-1539 logging_revamp replace module loggers SC-1539 May 8, 2023
@CalvoM CalvoM force-pushed the logging_revamp-replace_module_loggers branch 5 times, most recently from 088c2df to 4167b83 Compare May 15, 2023 13:53
@orndorffgrant orndorffgrant mentioned this pull request May 16, 2023
Merged
5 tasks
@CalvoM CalvoM force-pushed the logging_revamp-replace_module_loggers branch from 4167b83 to 6dcee0f Compare June 13, 2023 08:57
@github-actions
Copy link

github-actions bot commented Jun 13, 2023 •
edited
Loading

Jira: SC-1539

GitHub Issues: No GitHub issues are fixed by this PR. (No commits have Fixes: #### references)

Launchpad Bugs: No Launchpad bugs are fixed by this PR. (No commits have LP: #### references)

Documentation: The changes in this PR do not require documentation changes.

👍 this comment to confirm that this is correct.

@orndorffgrant
Copy link
Collaborator

Sorry for the churn, but we talked about this more on friday and I think we want to pre-emptively name the top-level logger ubuntu_pro instead of uaclient after all.

We can probably accomplish this with something like

LOG = logging.getLogger(replace_top_level_logger_name(__name__))

in most places, where that new function replaces uaclient with ubuntu_pro in the __name__ str

@CalvoM CalvoM force-pushed the logging_revamp-replace_module_loggers branch 4 times, most recently from 3175b1f to 4b137b7 Compare June 27, 2023 08:36
@CalvoM CalvoM force-pushed the logging_revamp-replace_module_loggers branch 2 times, most recently from 6c04f8d to 8178062 Compare June 30, 2023 15:24
lucasmoura
lucasmoura reviewed Jul 5, 2023
View reviewed changes
lib/auto_attach.py Outdated Show resolved Hide resolved
lib/apt_news.py Outdated Show resolved Hide resolved
orndorffgrant
orndorffgrant reviewed Jul 7, 2023
View reviewed changes
uaclient/api/api.py Outdated Show resolved Hide resolved
lib/timer.py Outdated Show resolved Hide resolved
uaclient/cli.py Outdated Show resolved Hide resolved
uaclient/system.py Outdated Show resolved Hide resolved
uaclient/timer/__init__.py Outdated Show resolved Hide resolved
uaclient/util.py Outdated Show resolved Hide resolved
uaclient/yaml.py Outdated Show resolved Hide resolved
uaclient/util.py Outdated Show resolved Hide resolved
@CalvoM CalvoM force-pushed the logging_revamp-replace_module_loggers branch 3 times, most recently from 1646924 to 3e4445d Compare July 21, 2023 11:44
@CalvoM CalvoM force-pushed the logging_revamp-replace_module_loggers branch 8 times, most recently from db94e56 to 27bde4f Compare July 25, 2023 10:52
orndorffgrant
orndorffgrant reviewed Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@orndorffgrant orndorffgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small nits then I think this will be ready!

lib/daemon.py Show resolved Hide resolved
uaclient/clouds/azure.py Outdated Show resolved Hide resolved
uaclient/clouds/gcp.py Outdated Show resolved Hide resolved
uaclient/daemon/poll_for_pro_license.py Outdated Show resolved Hide resolved
uaclient/daemon/retry_auto_attach.py Outdated Show resolved Hide resolved
uaclient/util.py Outdated Show resolved Hide resolved
@CalvoM CalvoM force-pushed the logging_revamp-replace_module_loggers branch 2 times, most recently from fcee78b to d3c0480 Compare July 27, 2023 08:31
@CalvoM CalvoM force-pushed the logging_revamp-replace_module_loggers branch 2 times, most recently from 60fada6 to 63053dc Compare July 27, 2023 15:06
@CalvoM CalvoM force-pushed the logging_revamp-replace_module_loggers branch from 63053dc to 809a67f Compare July 27, 2023 15:09
orndorffgrant
orndorffgrant approved these changes Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@orndorffgrant orndorffgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is a huge help to the organization of our loggers.

@orndorffgrant
Copy link
Collaborator

CI failures are unrelated to this PR

@orndorffgrant orndorffgrant merged commit e91726b into main Jul 27, 2023
20 of 23 checks passed
@orndorffgrant orndorffgrant deleted the logging_revamp-replace_module_loggers branch July 27, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasmoura lucasmoura lucasmoura left review comments

@orndorffgrant orndorffgrant orndorffgrant approved these changes

@renanrodrigo renanrodrigo Awaiting requested review from renanrodrigo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CalvoM @orndorffgrant @lucasmoura