-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(): pass return url (new payment methods) #201
Feat(): pass return url (new payment methods) #201
Conversation
…eat/pass_returnURL
✅ Deploy Preview for capacitor-community-stripe ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I've tested this solution with p24 (https://stripe.com/docs/payments/p24), and 3DSecure card confirmation (https://stripe.com/docs/payments/3d-secure) |
@@ -22,10 +22,10 @@ apply plugin: 'kotlin-android' | |||
apply plugin: 'kotlin-android-extensions' | |||
|
|||
android { | |||
compileSdkVersion project.hasProperty('compileSdkVersion') ? rootProject.ext.compileSdkVersion : 30 | |||
compileSdkVersion project.hasProperty('compileSdkVersion') ? rootProject.ext.compileSdkVersion : 32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capacitor 3's target & compile sdkVersion is 30. So if you need it, you will have to wait for a Capacitor4-compatible version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new payment methods was added in v19.1.0 of Android Stripe SDK (stripe/stripe-android#4489).
Unfortunately compileSdkVersion was bumped in 18.2.0 (stripe/stripe-android@7053906).
Maybe there is a way to choose a SKD version based on compileSdkVersion of parent project?
call.resolve() | ||
} else { | ||
call.reject("This was not a Stripe url – handle the URL normally as you would") | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This return may not need
@grzesebe Thanks for your great work and pull request! |
@rdlabo |
In fact, we have already pre-released a version that supports Capacitor4, and the android SDK version is already available in the master branch. Now you no longer have a problem accepting your pull request. Now we'll work on resolving the conflicts and doing the merge! |
Merged!! Now pre-release.
@grzesebe Thanks for great work!! 👉 #145 Thanks. |
Wow, that was fast :) |
Hi,
I was investigating possibility of using different payment methods ex: p24, Klarna...
It occurs that we only need to update the SDKs
On IOS it's also needed to pass "returnURL" param and handle URL callback after return to app from browser.
https://stripe.com/docs/payments/accept-a-payment?platform=ios&ui=payment-sheet#ios-set-up-return-url
I've tested it on IOS and Android Emulator and it seems to work pretty well.
Unfortunately I wasn't able to compile on Android without bumping
targetSdkVersion
andcompileSdkVersion
I'm handling URL like this: