-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(): pass return url (new payment methods) #201
Merged
rdlabo
merged 6 commits into
capacitor-community:master
from
grzesebe:feat/pass_returnURL
Aug 5, 2022
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e291d0e
updated stripe ios sdk version
grzesebe 4c873b2
added returnURL to ios
grzesebe cb7c3a2
added handleURLCallback method
grzesebe ddc42c2
Merge branch 'capacitor-community:master' into feat/pass_returnURL
grzesebe 516ec75
Merge branch 'master' of github.com:capacitor-community/stripe into f…
grzesebe 17c0580
feat(android): update to 20.7.0
grzesebe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,6 +34,32 @@ public class StripePlugin: CAPPlugin { | |
call.resolve() | ||
} | ||
|
||
@objc func handleURLCallback(_ call: CAPPluginCall) { | ||
self.paymentSheetExecutor.plugin = self | ||
self.paymentFlowExecutor.plugin = self | ||
self.applePayExecutor.plugin = self | ||
|
||
let urlString = call.getString("url") ?? "" | ||
|
||
if urlString == "" { | ||
call.reject("you must provide url returned from browser") | ||
return | ||
} | ||
|
||
let url = URL(string: urlString)! | ||
DispatchQueue.main.async { | ||
let stripeHandled = StripeAPI.handleURLCallback(with: url) | ||
if (stripeHandled) { | ||
call.resolve() | ||
} else { | ||
call.reject("This was not a Stripe url – handle the URL normally as you would") | ||
return | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This return may not need |
||
} | ||
} | ||
|
||
|
||
} | ||
|
||
@objc func createPaymentSheet(_ call: CAPPluginCall) { | ||
self.paymentSheetExecutor.createPaymentSheet(call) | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capacitor 3's target & compile sdkVersion is 30. So if you need it, you will have to wait for a Capacitor4-compatible version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new payment methods was added in v19.1.0 of Android Stripe SDK (stripe/stripe-android#4489).
Unfortunately compileSdkVersion was bumped in 18.2.0 (stripe/stripe-android@7053906).
Maybe there is a way to choose a SKD version based on compileSdkVersion of parent project?