fix(formatter): correct argument printing and member access chain logic #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: azjezz <[email protected]>
azjezz
added
Priority: High
azjezz
commented
Mar 8, 2025
| FormatSettings { | ||
| preserve_breaking_argument_list: true, | ||
| preserve_breaking_member_access_chain: true, | ||
| always_break_named_arguments_list: false, |
There was a problem hiding this comment.
@innocenzi instantation was always breaking into multiple lines because of this option, not a bug.
azjezz
commented
Mar 8, 2025
| function getControls(): array | ||
| { | ||
| return [ | ||
| ...($this->bufferEnabled ? ['esc' => 'select'] : ['/' => 'filter', 'space' => 'select']), |
There was a problem hiding this comment.
does not resolve #130, we just noticed that parens were missing in this case, and fixes it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 What Does This PR Do?
This PR addresses and fixes multiple bugs in the formatter related to argument lists, indentation, and member access chain breaking, as reported in issue #128.
🔍 Context & Motivation
The bugs fixed in this PR were causing incorrect formatting in specific scenarios involving argument lists, indentation within nested structures, and member access chain line breaking. These issues were reported by a user and negatively impacted the formatter's reliability and usability.
🛠️ Summary of Changes
📂 Affected Areas
🔗 Related Issues or PRs
Closes #128
📝 Notes for Reviewers