Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dbconn.Exec in checkpoint #328

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Use dbconn.Exec in checkpoint #328

merged 3 commits into from
Jul 8, 2024

Conversation

morgo
Copy link
Collaborator

@morgo morgo commented Jul 8, 2024

A Pull Request should be associated with an Issue.

We wish to have discussions in Issues. A single issue may be targeted by multiple PRs.
If you're offering a new feature or fixing anything, we'd like to know beforehand in Issues,
and potentially we'll be able to point development in a particular direction.
Further notes in https://github.com/cashapp/spirit/blob/main/.github/CONTRIBUTING.md

Fixes #327

@morgo morgo requested a review from jayjanssen July 8, 2024 13:58
jayjanssen
jayjanssen approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@jayjanssen jayjanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@morgo morgo merged commit a397dfe into main Jul 8, 2024
13 checks passed
@morgo morgo deleted the mtocker-fix-checkpoint branch July 8, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayjanssen jayjanssen jayjanssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change checkpoint to use dbconn.Exec instead of [sql].ExecContext
2 participants
@morgo @jayjanssen